-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented dbscan for RGDR #57
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Note that the Python 3.7 Windows build fails. This is due to an issue with the To silence this issue we can specify the version for netcdf4, which might resolve the error. However, for how long do we want to keep supporting Python 3.7? It will reach its end of life in a couple of months. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Perhaps combine all in one module (rgdr.py) and consider adding a transform
method.
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, let's follow it up in the next PR
Implements dbscan clustering functionality. The code included in here is sufficient to reproduce the prototype_RGDR notebook.
See the wip notebook
From @geek-yang:
not required, haversine uses radians.
--> currently supports n_targets == 1, see Supporting multiple target intervals in
map_correlation
. #56When these methods are implemented, we also need to validate the results:
weighing by area is required for reducing clusters to the mean of each cluster. This is implemented
Note: For RGDR we will want to support grouping the DBSCAN operations over splits, due to the computational intensity when working with full resolution data, see #58
This PR fixes #55
Still to be implemented, but out of scope for this PR:
map_correlation
. #56rgdr
#58