Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent output traintest #62

Merged
merged 10 commits into from
Sep 29, 2023
Merged

Consistent output traintest #62

merged 10 commits into from
Sep 29, 2023

Conversation

geek-yang
Copy link
Member

@geek-yang geek-yang commented Sep 20, 2023 •
edited
Loading

traintest now gives the output based on the input type of x, for instance:

  • if input x is [x1, x2], then the output from split function is a list
  • if input x is [x1], then the output from split function is a list
  • if input x is x1, then the output from split function is the same as x1

This PR addresses issue #61 .

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@geek-yang geek-yang marked this pull request as ready for review September 20, 2023 15:11
@BSchilperoort BSchilperoort self-requested a review September 21, 2023 05:31
BSchilperoort
BSchilperoort approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@BSchilperoort BSchilperoort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Just some comments about typing :)

lilio/traintest.py Show resolved Hide resolved
lilio/traintest.py Outdated Show resolved Hide resolved
lilio/traintest.py Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

97.3% 97.3% Coverage
0.0% 0.0% Duplication

BSchilperoort
BSchilperoort approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@BSchilperoort BSchilperoort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes! 👍

@geek-yang geek-yang merged commit ee8ff0a into main Sep 29, 2023
16 checks passed
@geek-yang geek-yang deleted the consistent_output_traintest branch September 29, 2023 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BSchilperoort BSchilperoort BSchilperoort approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geek-yang @BSchilperoort