Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update Run_MaxText_via_multihost_runner.md #620

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

docs: update Run_MaxText_via_multihost_runner.md #620

wants to merge 2 commits into from

Conversation

eltociear
Copy link
Contributor

minor fix

@evdcush evdcush mentioned this pull request Apr 28, 2024
Merged
@evdcush
Copy link

evdcush commented Apr 28, 2024

FYI this user, eltociear, makes trivial/vapid diffs to documentation in any trendy or recently public repo related to AI on github to feature in the contributors.

For example:

  • "Github" --> "GitHub"
  • "Huggingface" --> "Hugging Face"
  • "an" <--> "a"

or other inconsequential (spellcheck at best) diffs, to be a "contributor".

Ref:

This was referenced Apr 28, 2024
Merged
Closed
Closed
Open
Open
Open
Merged
This was referenced Apr 29, 2024
Open
Merged
Open
Closed
This was referenced May 8, 2024
Closed
Closed
Closed
Closed
Open
Closed
Closed
Closed
Meeklowg
Meeklowg reviewed Jun 19, 2024
View reviewed changes
Copy link

@Meeklowg Meeklowg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$Makeitback7

getting_started/Run_MaxText_via_multihost_runner.md
@@ -45,7 +45,7 @@ either be a TPUVM or not, but it cannot be one of the workers. If your runner ma
gcloud config set compute/zone $ZONE
```

Create ssh keys for gcloud, we recommend leaving a blank password (hit enter twice after running the below command). If you are prompted that the the file already exists you can choose not to overwrite by selecting "n".
Create ssh keys for gcloud, we recommend leaving a blank password (hit enter twice after running the below command). If you are prompted that the file already exists you can choose not to overwrite by selecting "n".
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...download...ALL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Meeklowg Meeklowg Meeklowg left review comments

@rwitten rwitten Awaiting requested review from rwitten

@gobbleturk gobbleturk Awaiting requested review from gobbleturk gobbleturk is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eltociear @evdcush @Meeklowg