Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implicit Translation Table Population #7

Merged
merged 1 commit into from
Feb 24, 2024
Merged

Implicit Translation Table Population #7

merged 1 commit into from
Feb 24, 2024

Conversation

AG3NTZ3R0
Copy link
Owner

Overview

  • A majority of the CNBC API endpoints require an issueId or issueIds parameter which is retrieved by way of the TRANSLATE endpoint
  • The implicit population of a translation table aims to minimize the number of additional requests whenever the TRANSLATE endpoint is requested within the APIWrapper class
  • The translation table can be loaded from and saved to a JSON file

AG3NTZ3R0
AG3NTZ3R0 commented Feb 24, 2024
View reviewed changes
Copy link
Owner Author

@AG3NTZ3R0 AG3NTZ3R0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are ready to be merged.

@AG3NTZ3R0 AG3NTZ3R0 merged commit 52a1a8c into master Feb 24, 2024
2 checks passed
@AG3NTZ3R0 AG3NTZ3R0 deleted the implicitSymbolTranslation branch February 24, 2024 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@AG3NTZ3R0