Separate Prometheus metrics into global and per-client categories with refactoring #2781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs a good |
domenukk
reviewed
Dec 18, 2024
libafl/src/monitors/prometheus.rs
Outdated
|
|
||
| impl PrometheusStats { | ||
| /// Create a new [`PrometheusStats`] with default values. | ||
| pub fn default() -> Self { |
There was a problem hiding this comment.
See clippy: This should probably be impl Default for PrometheusStats
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aggregated and per-client fuzzing stats were mixed in the Prometheus monitor, either the ones displayed on stderr and the ones served. The metrics were structured to show stats for each client, with Prometheus labels using
sender_id.0as an identifier. However, only thecustom_statswere actually per-client, while the rest (e.g., exec/s, objective_count, etc.) were all aggregated. This created confusion.I separated the metrics into two categories: global metrics and per-client metrics. Now, they are served separately. I also thought it would be nice and beautiful to display the parameter
edges_hit/edges_total, so I dared to add it in thecustom_stats.I refactored a bit the monitor here and there.