Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make llvm pass build feature dependent #2357

Merged
merged 4 commits into from
Jul 2, 2024
Merged

Make llvm pass build feature dependent #2357

merged 4 commits into from
Jul 2, 2024

Conversation

tokatoka
Copy link
Member

@tokatoka tokatoka commented Jul 2, 2024

No description provided.

domenukk
domenukk reviewed Jul 2, 2024
View reviewed changes
fuzzers/fuzzbench/Cargo.toml Outdated
@@ -29,7 +29,7 @@ libafl = { path = "../../libafl/" }
libafl_bolts = { path = "../../libafl_bolts/" }
libafl_targets = { path = "../../libafl_targets/", features = ["sancov_pcguard_hitcounts", "sancov_cmplog", "libfuzzer"] }
# TODO Include it only when building cc
libafl_cc = { path = "../../libafl_cc/" }
libafl_cc = { path = "../../libafl_cc/", features = ["autotokens", "cmplog-routines"] }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make those two default

@domenukk
Copy link
Member

domenukk commented Jul 2, 2024

Also should the names start with llvm_?
In theory we could support other compilers

@tokatoka
Copy link
Member Author

tokatoka commented Jul 2, 2024

Also should the names start with llvm_?
In theory we could support other compilers

No other part of libafl_cc already assumes the compiler is clang. it won't work with gcc even if we added it.
if we do this we better have different folder in libafl-gcc

@domenukk
Copy link
Member

domenukk commented Jul 2, 2024

Also should the names start with llvm_?
In theory we could support other compilers

No other part of libafl_cc already assumes the compiler is clang. it won't work with gcc even if we added it. if we do this we better have different folder in libafl-gcc

They don't? We specifically have a clang.rs with the idea to add a gcc.rs (or whatever) later

@tokatoka
Copy link
Member Author

tokatoka commented Jul 2, 2024 •
edited
Loading

build.rs is for clang..
but why does anybody want to use gcc when you certainly can install clang

@tokatoka tokatoka merged commit 762b6e0 into main Jul 2, 2024
97 checks passed
@tokatoka tokatoka deleted the make_llvm_pass_optional_feature branch July 2, 2024 15:37
@domenukk
Copy link
Member

domenukk commented Jul 2, 2024 •
edited
Loading

Some targets only work with gcc ¯\_(ツ)_/¯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenukk domenukk domenukk left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tokatoka @domenukk