-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swadge Hero Rechart #336
Merged
Merged
Swadge Hero Rechart #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix hold bit
Cleanup
Fix hold bit
Cleanup
Organize into files
Fix firmware build
Update colors
Documentation Cleanup
Enable general MIDI Reorganize assets
Fix up debug menu options, persistence, fanfare
Get tunernome clicking again Adjust tunernome LEDs Fix out of bounds memory access Add ability to swtich between DAC and ADC modes More safely access global midi players
Added tutorial steps for all peripherals
Factory test spk first, mic last Make touchpad tutorial clearer
Pango (#232) * fix bug with enemy behavior that throws off block counting * add hotdog particle and bonus item * start adding music (this is definitely unfinished) * Use drawWsgTile to increase FPS Midi (#299) * Don't sum oscillators for inactive voices or when current volume and target volume are both 0 * Always check for midi events at least once Graphics code * Set explicit RGB value for cTransparent (black) Gamepad (#278) * Start adding an option for Switch gamepad to use touchpad as extra buttons
Simplify metadata
AEFeinstein
commented
Dec 9, 2024
main/modes/games/pango/pango.c
Outdated
@@ -269,6 +269,9 @@ void pangoEnterMode(void) | |||
pango->tilemap.entityManager = &(pango->entityManager); | |||
pango->tilemap.tileSpawnEnabled = true; | |||
|
|||
pa_loadMapFromFile(&(pango->tilemap), "preset.bin"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JVeg199X do you know why this is in my PR? I merged from main
first and I didn't add this myself
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eh, whatever this was, I undid it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
General Swadge Hero Updates
Added and recharted Swadge Hero Songs
Test Instructions
It wasn't!
Ticket Links
#288
Readiness Checklist
make format
to format the changesmake cppcheck
and checked thatcppcheck_result.txt
has no warnings for the changes/*! \file
comments with Design Philosophy, Usage, and Example sections for new headers.make docs
and checked thatdoxy_warnings.txt
has no warnings for the new code