-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sokobokobanaban Instructions #332
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
using spiffs_image for output seamed easiest.
untested.
lots of cleanup still to do
needs caching. need to do for object layer next. the goal is that the id's can be random and it won't matter, we just lookup the tile 'type' in the data. removed errant levelVariants array re-adjusted binary representations now that it is handled gracefully
- ported 8 euler levels - added crate for euler theme - organized levels and sprites - added Euler theme - fixed entity collision bug - moved findIndex to save and fixed loading portals bug - importer works for portals properly - indices array is correctly set (bug fix) and used when creating portal entities.
added art fixed things still kinda hacky
- encoding euler tiles into a blob - fix reading/writing entities - rename pthings to soko in a few places - it sort of works
fixes a bug where when you restart the level, it would save and reload the save data. Which you usually don't want when you are hitting 'restart'.
- some new classic levels - run length compression scheme
Make sure NVS is read before using values Use const NVS keys Fix tile drawing Fix memory leak
Draw text with higher contrast
AEFeinstein
commented
Dec 1, 2024
Recolor Soko menu Turn off LEDs & Rings for soko instructions Fix Soko out of bounds
#328 Add UTTT pass-and-play
Track cell anim and sparkle anim separately Fix pause button
Use the player's marker for 2p local system Fix LEDs for CPU moves, result screen
hunterdyar
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
made some changes to the text to go with the title of "these are my puzzles for you".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added instructions.
Pressing start on the overworld returns to the main menu.
Fixed memory leak.
Test Instructions
Read instructions.
Press start to return to the main menu
Ticket Links
#218
Readiness Checklist
make format
to format the changesmake cppcheck
and checked thatcppcheck_result.txt
has no warnings for the changes/*! \file
comments with Design Philosophy, Usage, and Example sections for new headers.make docs
and checked thatdoxy_warnings.txt
has no warnings for the new code