Sequencer #305
Merged
Sequencer #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix hold bit
Cleanup
Fix hold bit
Cleanup
Organize into files
Fix firmware build
Use textColor when drawing text
Add separate callbacks for song and note menus
Thread safety for emulator Use note params
Snap cursor when changing grid Move cursor when playing
Play example when placing notes Never stop MIDI callbacks
Add per-instrument colors (notes & wheel) Refactor MIDI queue away
Actually place song end marker Stop or loop when the song end is hit Improve menu text Exit menu when selecting items Fast exit from fillDisplayArea() if nothing is drawn
Recolored sequencer menu
Rebuild menu after saving and loading Properly set default parameters Add option to reset current song Refactor, comment, remove dead code
commit de3ff3f Author: DebrisHauler <[email protected]> Date: Tue Oct 15 04:57:24 2024 -0400 Bigbug (#303) So many updates squashed into this commit! commit 5bc5704 Author: gelakinetic <[email protected]> Date: Sun Oct 6 19:16:36 2024 -0400 Swadge Hero (#301) * Adjust emulated LEDs to match hotdog * Add ability to recolor menu LEDs * Swadge Hero: FX and menu updates
commit de3ff3f Author: DebrisHauler <[email protected]> Date: Tue Oct 15 04:57:24 2024 -0400 Bigbug (#303) So many updates squashed into this commit! commit 5bc5704 Author: gelakinetic <[email protected]> Date: Sun Oct 6 19:16:36 2024 -0400 Swadge Hero (#301) * Adjust emulated LEDs to match hotdog * Add ability to recolor menu LEDs * Swadge Hero: FX and menu updates
Reorganize menu Fix bug where settings could change without being selected
Fix menu title outline bugs
Reset help index when entering again
Refactor & comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test Instructions
Ticket Links
#26
Readiness Checklist
make formatto format the changesmake cppcheckand checked thatcppcheck_result.txthas no warnings for the changes/*! \filecomments with Design Philosophy, Usage, and Example sections for new headers.make docsand checked thatdoxy_warnings.txthas no warnings for the new code