Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional scala suffix in published artifacts #44

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Conversation

mgosk
Copy link
Contributor

@mgosk mgosk commented Oct 23, 2024

New flag to optionally resign from adding scala_version in published artifacts.

My use case:

  • repository with conf/yaml/sql files
  • Tests in scala are checking correctness of configs against multiple Spark(and Scala versions)
  • Published Artifacts contains only conf files and are not scala specific

@mgosk mgosk changed the title Optional scala suffix in artifacts Optional scala suffix in published artifacts Oct 23, 2024
Copy link
Contributor

@kbielefe kbielefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks good.

@kbielefe kbielefe enabled auto-merge October 23, 2024 21:45
@kbielefe kbielefe merged commit a8a339b into ADTRAN:main Oct 23, 2024
2 checks passed
@kbielefe
Copy link
Contributor

Deploy failed for some permission issue. I will troubleshoot in the morning.

@kbielefe
Copy link
Contributor

I think it is published correctly. Please let me know @mgosk if there are any issues. Thanks again for the contribution.

@mgosk
Copy link
Contributor Author

mgosk commented Oct 26, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants