Progress on catalog version reporting

[marc-white]

Progress on #294 .

This PR updates the existing available_versions function to:

• Use pathlib.Path instead of the os module;
• Consider the min/max/default versions of the catalog specified in the catalog.yaml when reporting available versions;
• Mark the default version in the pretty printout return.

Tests have also been updated as required.

[codecov]

Codecov Report

Attention: Patch coverage is 81.81818% with 4 lines in your changes missing coverage. Please review.

Project coverage is 98.20%. Comparing base (2f5ba48) to head (6a9012d).
Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
src/access_nri_intake/data/utils.py	81.81%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #295      +/-   ##
==========================================
- Coverage   98.49%   98.20%   -0.29%     
==========================================
  Files          11       11              
  Lines         996     1058      +62     
==========================================
+ Hits          981     1039      +58     
- Misses         15       19       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[marc-white]

I added more tests, but codecov still thinks I'm not testing L60-63 of data.utils.available_versions.

[charles-turner-1]

I'll take a proper look at this first thing tomorrow morning.

[charles-turner-1]

I suspect that codecov might be getting upset because of the way the mocks are defined?
eg. test_data:

@mock.patch("access_nri_intake.data.utils.get_catalog_fp")
-77 def test_available_versions_no_catalog(mock_get_catalog_fp):
-78    mock_get_catalog_fp.return_value = "/this/is/not/real.yaml"
-79    with pytest.raises(FileNotFoundError):
-80        available_versions()

+ @mock.patch("access_nri_intake.data.utils.get_catalog_fp")
+ def test_available_versions_no_catalog(mock_get_catalog_fp):
+    mock_get_catalog_fp.return_value = "/this/is/not/real.yaml"
+    with pytest.raises(FileNotFoundError):
+        available_versions()

Intellisense is complaining to me that the mock_get_catalog_fp fixture is unused - maybe that's what's throwing codecov off the trail?

Otherwise, a few minor nitpicks (I think I'm a bit jumpy after letting the overflow bug into main) but otherwise looks good.

[charles-turner-1]

Whoops, accidentally requested a review instead of giving one...

[charles-turner-1]

Looks to me like codecov is talking nonsense, so I think this is ready to merge.