Skip to content

Commit

Permalink
Merge pull request #116 from ACCESS-Cloud-Based-InSAR/remove-3.8
Browse files Browse the repository at this point in the history
Remove python 3.8 support
  • Loading branch information
cmarshak authored Mar 21, 2023
2 parents cda63f5 + cdd6a12 commit 0f4a142
Show file tree
Hide file tree
Showing 4 changed files with 18 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: ["3.8", "3.9"]
python-version: ["3.9"]

steps:
- uses: actions/checkout@v2
Expand Down
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,11 @@ and uses [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

### Added

## [0.2.3]

## Removed
* Python 3.8 Support

## [0.2.2]

### Added
Expand Down
10 changes: 10 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,16 @@ docker run -ti -v $PWD:/home/ops/topsapp_data topsapp_img \
```
where the `username`/`password` are the Earthdata credentials for accessing NASA data. We note the command line magic of the above is taken care of the `isce2_topsapp/etc/entrypoint.sh` (written by Joe Kennedy) which automatically runs certain bash commands on startup of the container, i.e. the run commands also calls the `isce2_topsapp` command line function as can be seen [here](isce2_topsapp/etc/entrypoint.sh).

# Build Issues

ISCE2, gdal, and xarray are hard to balance. Ideally, we would have a dependabot to increment packages and integration tests to make sure datasets are generated correctly with each update. Unfortunately, this is not currently the case. So, we are including some snippets (credit to Joseph Kennedy) for determining where packages might fail. We have some caps in our environment.yml file. This is how we find them. Sometimes even with our rather minimal integration tests and builds, in 24 hours, a new package can entirely throw something awry with respect to builds.

The easiest way to see what was the *last* working build, check out the docker [images](https://github.com/ACCESS-Cloud-Based-InSAR/DockerizedTopsApp/pkgs/container/dockerizedtopsapp) for the last build. `latest` refers to the latest production build on `main`. `test` refers to the last build on `dev`. But each merge to `dev` gets an image that is recorded.

1. Click one of the images and it will tell you how to download an image into docker e.g. `docker pull ghcr.io/access-cloud-based-insar/dockerizedtopsapp:0.2.2.dev148_gab75888`.
2. Load the image and get into interactive mode e.g. `docker run --entrypoint /usr/bin/bash -it --rm ghcr.io/access-cloud-based-insar/dockerizedtopsapp:0.2.2.dev136_ga2d5389 -l`
3. Check the packages `conda list | grep xarray`

## FAQ

1. The docker build is taking a long time.
Expand Down
7 changes: 2 additions & 5 deletions environment.yml
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
name: topsapp_env
channels:
- conda-forge
- anaconda
- defaults
dependencies:
- python>=3.8,<3.10
- python>=3.9,<3.10
- pip
- affine
- asf_search>=5.0.0
Expand Down Expand Up @@ -35,12 +33,11 @@ dependencies:
- pytest-cov
- pytest-mock
- rasterio
- rioxarray
- rioxarray<0.14.0
- xarray
- scipy<1.10
- setuptools
- setuptools_scm
- scipy<1.10
- shapely
- tqdm
- dem_stitcher>=2.4.0
Expand Down

0 comments on commit 0f4a142

Please sign in to comment.