Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

๐Ÿ”จ Refactor/#192 - ๊ธธ์ฐพ๊ธฐ๋ฅผ ์œ„ํ•œ Store์— ์œ„๊ฒฝ๋„ ์ถ”๊ฐ€, ๊ฐ€๊ฒŒ ์ƒ์„ธ์กฐํšŒ Response ๋ณ€๊ฒฝ #193

Merged
merged 1 commit into from
Dec 5, 2024
Merged

๐Ÿ”จ Refactor/#192 - ๊ธธ์ฐพ๊ธฐ๋ฅผ ์œ„ํ•œ Store์— ์œ„๊ฒฝ๋„ ์ถ”๊ฐ€, ๊ฐ€๊ฒŒ ์ƒ์„ธ์กฐํšŒ Response ๋ณ€๊ฒฝ #193

merged 1 commit into from
Dec 5, 2024

Conversation

dongkyeomjang
Copy link
Collaborator

@dongkyeomjang dongkyeomjang commented Dec 5, 2024 •
edited
Loading

Related issue ๐Ÿ› 

closed #192

์–ด๋–ค ๋ณ€๊ฒฝ์‚ฌํ•ญ์ด ์žˆ์—ˆ๋‚˜์š”?

  • ๐Ÿž BugFix Something isn't working
  • ๐Ÿ’ป CrossBrowsing Browser compatibility
  • ๐ŸŒ Deploy Deploy
  • ๐ŸŽจ Design Markup & styling
  • ๐Ÿ“ƒ Docs Documentation writing and editing (README.md, etc.)
  • โœจ Feature Feature
  • ๐Ÿ”จ Refactor Code refactoring
  • โš™๏ธ Setting Development environment setup
  • โœ… Test Test related (storybook, jest, etc.)

CheckPoint โœ…

PR์ด ๋‹ค์Œ ์š”๊ตฌ ์‚ฌํ•ญ์„ ์ถฉ์กฑํ•˜๋Š”์ง€ ํ™•์ธํ•˜์„ธ์š”.

  • PR ์ปจ๋ฒค์…˜์— ๋งž๊ฒŒ ์ž‘์„ฑํ–ˆ์Šต๋‹ˆ๋‹ค. (ํ•„์ˆ˜)
  • Docker Container ํ™˜๊ฒฝ์œผ๋กœ ๋ณ€๊ฒฝ ์‚ฌํ•ญ์— ๋Œ€ํ•œ ํ…Œ์ŠคํŠธ๋ฅผ ํ–ˆ์Šต๋‹ˆ๋‹ค.(๋ฒ„๊ทธ ์ˆ˜์ •/๊ธฐ๋Šฅ์— ๋Œ€ํ•œ ํ…Œ์ŠคํŠธ). (ํ•„์ˆ˜)
  • Feature์˜ ๊ฒฝ์šฐ, API ๋ฌธ์„œ ์—…๋ฐ์ดํŠธ๋ฅผ ์™„๋ฃŒํ–ˆ์Šต๋‹ˆ๋‹ค. (์„ ํƒ)
  • BugFix์˜ ๊ฒฝ์šฐ, ๋ฒ„๊ทธ์˜ ์›์ธ์„ ํŒŒ์•…ํ•˜์˜€์Šต๋‹ˆ๋‹ค. (์„ ํƒ)

Work Description โœ๏ธ

  • ๐Ÿ”จ Refactor - ๊ธธ์ฐพ๊ธฐ๋ฅผ ์œ„ํ•œ Store์— ์œ„๊ฒฝ๋„ ์ถ”๊ฐ€, ๊ฐ€๊ฒŒ ์ƒ์„ธ์กฐํšŒ Response ๋ณ€๊ฒฝ

Uncompleted Tasks ๐Ÿ˜…

  • Task1

To Reviewers ๐Ÿ“ข

@dongkyeomjang dongkyeomjang added ๐Ÿ”จ Refactor ์ฝ”๋“œ ๋ฆฌํŒฉํ† ๋ง dongkyeomjang assigned to dongkyeomjang labels Dec 5, 2024
@dongkyeomjang dongkyeomjang self-assigned this Dec 5, 2024
@dongkyeomjang dongkyeomjang linked an issue Dec 5, 2024 that may be closed by this pull request
๐Ÿ”จ Refactor - ๊ธธ์ฐพ๊ธฐ๋ฅผ ์œ„ํ•œ Store์— ์œ„๊ฒฝ๋„ ์ถ”๊ฐ€, ๊ฐ€๊ฒŒ ์ƒ์„ธ์กฐํšŒ Response ๋ณ€๊ฒฝ #192
Closed
1 task
@dongkyeomjang dongkyeomjang merged commit 2b3da24 into dev Dec 5, 2024
1 check passed
@dongkyeomjang dongkyeomjang deleted the Refactor/#192 branch December 5, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bianbbc87 bianbbc87 Awaiting requested review from bianbbc87 bianbbc87 is a code owner

Assignees

@dongkyeomjang dongkyeomjang

Labels
dongkyeomjang assigned to dongkyeomjang ๐Ÿ”จ Refactor ์ฝ”๋“œ ๋ฆฌํŒฉํ† ๋ง
Projects
None yet
Milestone
No milestone
1 participant
@dongkyeomjang