docs: fix hostname matching with --init-hooks #1215
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change #1182 had the intention to evaluate 'uname -n' while calling 'distrobox-create'. But had the quotation marks wrong. Double quotation marks must be the outer ones for the evaluation to occur directly. When changing /etc/hostname, hostname does not change without a reboot. To avoid forcing the user to reboot the container after creating and entering the container, add 'hostname $(uname -n)' to be called with the --init-hooks flag. See related issue #1164
|
Hi @robinhellmers thanks for the PR but this has been obsoleted by #1214 and now we have a dedicated flag to set hostnames Thanks anyway for the work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change #1182 had the intention to evaluate 'uname -n' while calling 'distrobox-create'. But had the quotation marks wrong. Double quotation marks must be the outer ones for the evaluation to occur directly.
When changing /etc/hostname, hostname does not change without a reboot. To avoid forcing the user to reboot the container after creating and entering the container, add 'hostname $(uname -n)' to be called with the --init-hooks flag.
See related issue #1164