Merge pull request #15 from 7SOATSquad30/refactor/move-order-invariants

refactor: move order invariants to the entity
7SOATSquad30 · May 20, 2024 · 1a979bb · 1a979bb
2 parents 9b24d05 + 0afc62f
commit 1a979bb
Show file tree

Hide file tree

Showing 6 changed files with 44 additions and 33 deletions.
diff --git a/...o30/fastfood/application/services/exceptions/CantSubmitOrderWithoutProductsException.java b/...o30/fastfood/application/services/exceptions/CantSubmitOrderWithoutProductsException.java
diff --git a/.../grupo30/fastfood/application/services/exceptions/CompositeDomainValidationException.java b/.../grupo30/fastfood/application/services/exceptions/CompositeDomainValidationException.java
@@ -0,0 +1,18 @@
+package br.com.fiap.grupo30.fastfood.application.services.exceptions;
+
+import java.io.Serial;
+import java.util.Collection;
+
+public class CompositeDomainValidationException extends ResourceBadRequestException {
+
+    @Serial private static final long serialVersionUID = 1L;
+
+    public CompositeDomainValidationException(Collection<String> domainErrors) {
+        super(String.join(", ", domainErrors));
+    }
+
+    public CompositeDomainValidationException(
+            Collection<String> domainErrors, Throwable exception) {
+        super(String.join(", ", domainErrors), exception);
+    }
+}
diff --git a/...ain/java/br/com/fiap/grupo30/fastfood/domain/usecases/order/AddProductToOrderUseCase.java b/...ain/java/br/com/fiap/grupo30/fastfood/domain/usecases/order/AddProductToOrderUseCase.java
@@ -1,7 +1,6 @@
 package br.com.fiap.grupo30.fastfood.domain.usecases.order;
 
 import br.com.fiap.grupo30.fastfood.application.dto.OrderDTO;
-import br.com.fiap.grupo30.fastfood.application.services.exceptions.CantChangeOrderProductsAfterSubmitException;
 import br.com.fiap.grupo30.fastfood.application.services.exceptions.ResourceNotFoundException;
 import br.com.fiap.grupo30.fastfood.infrastructure.out.persistence.jpa.entities.OrderEntity;
 import br.com.fiap.grupo30.fastfood.infrastructure.out.persistence.jpa.entities.ProductEntity;
@@ -31,10 +30,6 @@ public OrderDTO execute(Long orderId, Long productId, Long productQuantity) {
                         .findById(orderId)
                         .orElseThrow(() -> new ResourceNotFoundException("Order not found"));
 
-        if (!order.isDraft()) {
-            throw new CantChangeOrderProductsAfterSubmitException();
-        }
-
         ProductEntity product =
                 this.productRepository
                         .findById(productId)

diff --git a/...ava/br/com/fiap/grupo30/fastfood/domain/usecases/order/RemoveProductFromOrderUseCase.java b/...ava/br/com/fiap/grupo30/fastfood/domain/usecases/order/RemoveProductFromOrderUseCase.java
@@ -1,7 +1,6 @@
 package br.com.fiap.grupo30.fastfood.domain.usecases.order;
 
 import br.com.fiap.grupo30.fastfood.application.dto.OrderDTO;
-import br.com.fiap.grupo30.fastfood.application.services.exceptions.CantChangeOrderProductsAfterSubmitException;
 import br.com.fiap.grupo30.fastfood.application.services.exceptions.ResourceNotFoundException;
 import br.com.fiap.grupo30.fastfood.infrastructure.out.persistence.jpa.entities.OrderEntity;
 import br.com.fiap.grupo30.fastfood.infrastructure.out.persistence.jpa.entities.ProductEntity;
@@ -29,10 +28,6 @@ public OrderDTO execute(Long orderId, Long productId) {
                         .findById(orderId)
                         .orElseThrow(() -> new ResourceNotFoundException("Order not found"));
 
-        if (!order.isDraft()) {
-            throw new CantChangeOrderProductsAfterSubmitException();
-        }
-
         ProductEntity product =
                 this.productRepository
                         .findById(productId)

diff --git a/src/main/java/br/com/fiap/grupo30/fastfood/domain/usecases/order/SubmitOrderUseCase.java b/src/main/java/br/com/fiap/grupo30/fastfood/domain/usecases/order/SubmitOrderUseCase.java
@@ -1,7 +1,6 @@
 package br.com.fiap.grupo30.fastfood.domain.usecases.order;
 
 import br.com.fiap.grupo30.fastfood.application.dto.OrderDTO;
-import br.com.fiap.grupo30.fastfood.application.services.exceptions.CantSubmitOrderWithoutProductsException;
 import br.com.fiap.grupo30.fastfood.application.services.exceptions.ResourceNotFoundException;
 import br.com.fiap.grupo30.fastfood.infrastructure.out.persistence.jpa.entities.OrderEntity;
 import br.com.fiap.grupo30.fastfood.infrastructure.out.persistence.jpa.entities.OrderStatus;
@@ -25,10 +24,6 @@ public OrderDTO execute(Long orderId) {
                         .findById(orderId)
                         .orElseThrow(() -> new ResourceNotFoundException("Order not found"));
 
-        if (!order.hasProducts()) {
-            throw new CantSubmitOrderWithoutProductsException();
-        }
-
         order.setStatus(OrderStatus.SUBMITTED);
         return this.orderRepository.save(order).toDTO();
     }

diff --git a/...br/com/fiap/grupo30/fastfood/infrastructure/out/persistence/jpa/entities/OrderEntity.java b/...br/com/fiap/grupo30/fastfood/infrastructure/out/persistence/jpa/entities/OrderEntity.java
@@ -2,6 +2,8 @@
 
 import br.com.fiap.grupo30.fastfood.application.dto.OrderDTO;
 import br.com.fiap.grupo30.fastfood.application.dto.OrderItemDTO;
+import br.com.fiap.grupo30.fastfood.application.services.exceptions.CantChangeOrderProductsAfterSubmitException;
+import br.com.fiap.grupo30.fastfood.application.services.exceptions.CompositeDomainValidationException;
 import jakarta.persistence.*;
 import java.time.Instant;
 import java.util.Collection;
@@ -42,6 +44,10 @@ public class OrderEntity {
     private Instant deletedAt;
 
     public void addProduct(ProductEntity product, Long quantity) {
+        if (!this.isDraft()) {
+            throw new CantChangeOrderProductsAfterSubmitException();
+        }
+
         this.items.stream()
                 .filter(orderItem -> orderItem.getProduct().equals(product))
                 .findFirst()
@@ -54,6 +60,10 @@ public void addProduct(ProductEntity product, Long quantity) {
     }
 
     public void removeProduct(ProductEntity product) {
+        if (!this.isDraft()) {
+            throw new CantChangeOrderProductsAfterSubmitException();
+        }
+
         this.items.removeIf(orderItem -> orderItem.getProduct().equals(product));
 
         this.recalculateTotalPrice();
@@ -67,18 +77,30 @@ private void recalculateTotalPrice() {
         this.totalPrice = this.items.stream().mapToDouble(item -> item.getTotalPrice()).sum();
     }
 
-    public Boolean isDraft() {
+    private Boolean isDraft() {
         return OrderStatus.DRAFT.equals(this.status);
     }
 
-    public Boolean hasProducts() {
+    private Boolean hasProducts() {
         return !this.items.isEmpty();
     }
 
     public void setStatus(OrderStatus status) {
         this.status = status;
     }
 
+    public void validate() {
+        var errors = new LinkedList<String>();
+
+        if (this.status == OrderStatus.SUBMITTED && !this.hasProducts()) {
+            errors.add("Can not submit order without products");
+        }
+
+        if (!errors.isEmpty()) {
+            throw new CompositeDomainValidationException(errors);
+        }
+    }
+
     @PostLoad
     protected void postLoad() {
         recalculateTotalPrice();
@@ -87,11 +109,13 @@ protected void postLoad() {
     @PrePersist
     protected void prePersist() {
         createdAt = Instant.now();
+        this.validate();
     }
 
     @PreUpdate
     protected void preUpdate() {
         updatedAt = Instant.now();
+        this.validate();
     }
 
     @PreRemove