Fixed: Throw an exception if both lazyMultiple and multiple are set #106

75lb · Nov 10, 2023 · 3a754b7 · 3a754b7
1 parent bfc3d9d
commit 3a754b7
Show file tree

Hide file tree

Showing 5 changed files with 62 additions and 0 deletions.
diff --git a/dist/index.js b/dist/index.js
@@ -947,6 +947,16 @@ class Definitions extends Array {
         `A boolean option ["${invalidOption.name}"] can not also be the defaultOption.`
       );
     }
+
+    const multipleAndLazyMultiple = this.some(def => {
+      return def.multiple && def.lazyMultiple
+    });
+    if (multipleAndLazyMultiple) {
+      halt(
+        'INVALID DEFINITIONS',
+        'Multiple and LazyMultiple are exclusive options.'
+      );
+    }
   }
 
   /**

diff --git a/dist/index.mjs b/dist/index.mjs
@@ -943,6 +943,16 @@ class Definitions extends Array {
         `A boolean option ["${invalidOption.name}"] can not also be the defaultOption.`
       );
     }
+
+    const multipleAndLazyMultiple = this.some(def => {
+      return def.multiple && def.lazyMultiple
+    });
+    if (multipleAndLazyMultiple) {
+      halt(
+        'INVALID DEFINITIONS',
+        'Multiple and LazyMultiple are exclusive options.'
+      );
+    }
   }
 
   /**

diff --git a/dist/tests.js b/dist/tests.js
@@ -949,6 +949,16 @@ class Definitions extends Array {
         `A boolean option ["${invalidOption.name}"] can not also be the defaultOption.`
       );
     }
+
+    const multipleAndLazyMultiple = this.some(def => {
+      return def.multiple && def.lazyMultiple
+    });
+    if (multipleAndLazyMultiple) {
+      halt(
+        'INVALID DEFINITIONS',
+        'Multiple and LazyMultiple are exclusive options.'
+      );
+    }
   }
 
   /**
@@ -3218,6 +3228,17 @@ runner$l.test('multiple: string, defaultOption', function () {
   });
 });
 
+runner$l.test('multiple: with lazyMultiple throws exception', function () {
+  const optionDefinitions = [
+    { name: 'one', multiple: true, lazyMultiple: true }
+  ];
+  const argv = [];
+  const errorThrowingWrapper = () => {
+    commandLineArgs(optionDefinitions, { argv });
+  };
+  a.throws(errorThrowingWrapper);
+});
+
 const runner$m = new TestRunner();
 
 runner$m.test('name-alias-mix: one of each', function () {

diff --git a/lib/option-definitions.mjs b/lib/option-definitions.mjs
@@ -102,6 +102,16 @@ class Definitions extends Array {
         `A boolean option ["${invalidOption.name}"] can not also be the defaultOption.`
       )
     }
+
+    const multipleAndLazyMultiple = this.some(def => {
+      return def.multiple && def.lazyMultiple
+    })
+    if (multipleAndLazyMultiple) {
+      halt(
+        'INVALID DEFINITIONS',
+        'Multiple and LazyMultiple are exclusive options.'
+      )
+    }
   }
 
   /**

diff --git a/test/multiple.mjs b/test/multiple.mjs
@@ -74,3 +74,14 @@ runner.test('multiple: string, defaultOption', function () {
     one: ['1', '2']
   })
 })
+
+runner.test('multiple: with lazyMultiple throws exception', function () {
+  const optionDefinitions = [
+    { name: 'one', multiple: true, lazyMultiple: true }
+  ]
+  const argv = []
+  const errorThrowingWrapper = () => {
+    commandLineArgs(optionDefinitions, { argv })
+  }
+  a.throws(errorThrowingWrapper)
+})