Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

style: Adjust gap between pendings txs on dashboard widget #3837

Merged
merged 1 commit into from
May 2, 2022

Conversation

usame-algan
Copy link
Member

What it solves

Part of #3693

The space between pending transactions in the dashboard widget was stretched if there were less than 4 transactions.

How this PR fixes it

Instead of stretching the space, there is a fixed gap between each transaction. The gap is also slightly increased so that the space is filled when there are 4 transactions displayed.

How to test it

  1. Open the safe app
  2. Navigate to the dashboard
  3. With less than 4 transactions, observe whitespace at the bottom of the widget
  4. With 4 transactions, observe the pending tx widget has the same height as the featured apps widget

Screenshots

Screenshot 2022-04-28 at 15 58 05
Screenshot 2022-04-28 at 15 58 18

@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

Copy link
Member

@iamacook iamacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@github-actions
Copy link

Deployment links

🟠 Rinkeby Mainnet 🟣 Polygon 🟡 BSC Arbitrum 🟢 Gnosis Chain

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2239763962

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 35.33%

Totals Coverage Status
Change from base Build 2233611204: 0.0%
Covered Lines: 3595
Relevant Lines: 9236

💛 - Coveralls

@francovenica
Copy link
Contributor

Weird, pretty sure it wasn't broken like that when we released it.

Looks good to me. The tx are listed from top to bottom with the same distance between the tx.

2 comparison snapshots from this PR and dev to see the difference:
This PR:
image

Dev:
image

@usame-algan usame-algan merged commit 83276a7 into dev May 2, 2022
@usame-algan usame-algan deleted the fix-pending-txs-gap branch May 2, 2022 07:41
@github-actions github-actions bot locked and limited conversation to collaborators May 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants