Skip to content
This repository has been archived by the owner on Aug 28, 2023. It is now read-only.

Add tags to SafeApp #851

Merged
merged 1 commit into from
Apr 13, 2022
Merged

Add tags to SafeApp #851

merged 1 commit into from
Apr 13, 2022

Conversation

fmrsabino
Copy link
Contributor

Related with safe-global/safe-config-service#486 and 5afe/safe-react#3698

  • Enables serialisation and deserialisation of tags for a SafeApp
  • Serialisation is enabled IFF SAFE_APPS_TAGS_FEATURE_ENABLED is set to true
GET /v1/chains/<chain_id>/safe-apps

{
    "id": 1,
    "name": "OpenZeppelin",
    "tags": [
	    "tag1",
	    "tag2",
	    "tag3"
    ]
    ...
}

@fmrsabino fmrsabino requested review from a team, rmeissner, Uxio0 and luarx April 13, 2022 10:50
@fmrsabino fmrsabino self-assigned this Apr 13, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2160682873

  • 43 of 45 (95.56%) changed or added relevant lines in 6 files are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.02%) to 88.671%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/common/models/backend/safe_apps.rs 0 1 0.0%
src/routes/safe_apps/tests/routes.rs 31 32 96.88%
Files with Coverage Reduction New Missed Lines %
src/routes/safe_apps/converters.rs 1 58.57%
src/common/converters/tests/safe_app.rs 5 60.76%
Totals Coverage Status
Change from base Build 2102745780: 0.02%
Covered Lines: 11881
Relevant Lines: 13399

💛 - Coveralls

@fmrsabino fmrsabino merged commit 8922d05 into main Apr 13, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 13, 2022
@fmrsabino fmrsabino deleted the add-tags-safe-apps branch April 13, 2022 12:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants