Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plone 5.2 Support #7214

Draft
wants to merge 32 commits into
base: master
Choose a base branch
from
Draft

Plone 5.2 Support #7214

wants to merge 32 commits into from

Conversation

buchi
Copy link
Member

@buchi buchi commented Oct 18, 2021

PR-Description: should contain all the information necessary for an outsider to understand the change without looking at the code or the issue!

  • Why the change is necessary
  • What the goal of the change is
  • How change is achieved (e.g. design decisions)
  • The author should advertise and sell the change in the PR body

Screenshot: whenever useful, but only as a visual aid.

Definition of Done: https://4teamwork.atlassian.net/wiki/spaces/CHX4TW/pages/917562/

For [CA-XXXX]

Checklist

Everything has to be done/checked. Checked but not present means the author deemed it unnecessary.

  • Changelog entry
  • Link to issue (Jira or GitHub) and backlink in issue (Jira)

Only applicable should be left and checked.

  • API change:
    • Documentation is updated
    • API Changelog entry (see guide)
    • If breaking:
      • api-change label added
      • #delivery channel notified about breaking change
      • Scrum master is informed
  • New functionality:
    • for document also works for mail
    • for task also works for forwarding
  • Further improvements needed:
    • Create follow-up stories and link them in the PR and Jira issue
  • Upgrade steps (changes in profile):
    • Make it deferrable if possible
    • Execute as much as possible conditionally
  • DB-Schema migration
    • All changes on a model (columns, etc) are included in a DB-schema migration.
    • Constraint names are shorter than 30 characters (Oracle)
  • Change could impact client installations, client policies need to be adapted
  • New translations
    • All msg-strings are unicode
  • Change in schema definition:
    • If missing_value is specified, then default has to be set to the same value

buchi added 30 commits October 12, 2021 12:11
Plone 5.2.5 requires newer versions.
Remove Archetypes event subscriber.
Disable ZMI patch.
Remove plone.app.blob dependency
Remove dependency on Products.ATContentTypes
Remove Archetypes dependency
buchi added 2 commits October 15, 2021 14:31
There are upgrade steps that contain imports that do not work with
Plone 5.2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant