Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test #6289

Closed
wants to merge 1 commit into from
Closed

Test #6289

wants to merge 1 commit into from

Conversation

elioschmutz
Copy link
Member

@elioschmutz elioschmutz commented Feb 27, 2020 •
edited by lukasgraf
Loading

Test

@elioschmutz elioschmutz requested a review from a team February 27, 2020 12:23
@elioschmutz elioschmutz self-assigned this Feb 27, 2020
@elioschmutz elioschmutz force-pushed the es-6206-fix-js-injections branch 2 times, most recently from c374e2c to 6443777 Compare February 27, 2020 13:38
njohner
njohner approved these changes Mar 3, 2020
View reviewed changes
Copy link
Contributor

@njohner njohner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we should open an issue to port that to plone maybe?

opengever/base/tests/test_widget.py Outdated

path, title = items[0].split('|')
self.assertEqual('/'.join(self.subdossier.getPhysicalPath()), path)
self.assertEqual('Evil <script></script>', title, 'The item')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✂️ The item

@elioschmutz elioschmutz force-pushed the es-6206-fix-js-injections branch from 6443777 to afb1c05 Compare March 3, 2020 13:42
@elioschmutz elioschmutz changed the title Fix XSS Test Mar 6, 2020
@elioschmutz elioschmutz force-pushed the es-6206-fix-js-injections branch from afb1c05 to 081235e Compare March 6, 2020 11:10
@elioschmutz elioschmutz closed this Mar 6, 2020
@elioschmutz elioschmutz deleted the es-6206-fix-js-injections branch March 6, 2020 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njohner njohner njohner approved these changes

Assignees

@elioschmutz elioschmutz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elioschmutz @njohner