Skip to content

Commit

Permalink
Delegate signers management to the external sign service
Browse files Browse the repository at this point in the history
  • Loading branch information
elioschmutz committed Dec 13, 2024
1 parent 2d4dc5d commit 22a6e02
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
1 change: 1 addition & 0 deletions changes/TI-1594.feature
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Delegate signers management to the external sign service. [elioschmutz]
6 changes: 4 additions & 2 deletions opengever/document/tests/test_document_workflow.py
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,8 @@ def test_can_start_signing_a_document_in_draft_state(self, mocker):
'created': u'2024-02-18T15:45:00',
'job_id': '1',
'redirect_url': 'http://external.example.org/signing-requests/123',
'signers': [
'signers': [],
'editors': [
{
'email': '[email protected]',
'userid': 'regular_user',
Expand Down Expand Up @@ -260,7 +261,8 @@ def test_can_start_signing_a_document_in_final_state(self, mocker):
'created': u'2024-02-18T15:45:00',
'job_id': '1',
'redirect_url': 'http://external.example.org/signing-requests/123',
'signers': [
'signers': [],
'editors': [
{
'email': '[email protected]',
'userid': 'regular_user',
Expand Down
2 changes: 1 addition & 1 deletion opengever/document/transition.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ def after_transition_hook(self, *args, **kwargs):
if not actor or not actor.email:
raise NoEmailError()

Signer(self.context).start_signing(signers=[actor.email])
Signer(self.context).start_signing(editors=[actor.email])


@implementer(ITransitionExtender)
Expand Down

0 comments on commit 22a6e02

Please sign in to comment.