Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fix compile with python 3.10 #43

Open
wants to merge 2 commits into
base: feat/hybridse-zetasql
Choose a base branch
from
Open

build: fix compile with python 3.10 #43

wants to merge 2 commits into from

Conversation

aceforeverd
Copy link
Collaborator

@aceforeverd aceforeverd commented Oct 16, 2022 •
edited
Loading

  • fix compile with python 3.10
    • resolved the import error: cannot import name 'Mapping' from 'collections', by upgrade jinja version
  • use python 3.10 as default python interrupter in macos job
    • it is default python2 in macos environment
    • python2 will not supported

@aceforeverd aceforeverd changed the title build: fix compile with python 3.10 build: fix compile with on macos Oct 26, 2022
@aceforeverd aceforeverd mentioned this pull request Oct 27, 2022
Merged
@aceforeverd
Copy link
Collaborator Author

Not fixed. It seems it should upgrade protobuf version.

@aceforeverd aceforeverd marked this pull request as draft October 27, 2022 02:35
@aceforeverd aceforeverd marked this pull request as ready for review October 27, 2022 03:58
@aceforeverd aceforeverd changed the title build: fix compile with on macos build: fix compile with python 3.10 Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aceforeverd