Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade third-party to 0.6.1 #3736

Merged
merged 8 commits into from
Feb 22, 2024
Merged

Conversation

dl239
Copy link
Collaborator

@dl239 dl239 commented Jan 30, 2024

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

@github-actions github-actions bot added the docker openmldb compile image or demo image label Jan 30, 2024
@dl239 dl239 changed the title feat: upgrade thirdparty to 0.6.1 feat: upgrade third-party to 0.6.1 Jan 30, 2024
docker/Dockerfile Outdated Show resolved Hide resolved
@aceforeverd
Copy link
Collaborator

u need upgrade in third-party/ first:

set(HYBRIDSQL_ASSERTS_HOME https://github.com/4paradigm/hybridsql-asserts)
set(HYBRIDSQL_ASSERTS_VERSION 0.6.0)

@github-actions github-actions bot added the build openmldb compiling and installing label Jan 31, 2024
Copy link
Contributor

github-actions bot commented Jan 31, 2024

SDK Test Report

101 files  ±0  101 suites  ±0   2m 4s ⏱️ -2s
344 tests ±0  330 ✅  - 1  14 💤 +1  0 ❌ ±0 
469 runs  ±0  455 ✅  - 1  14 💤 +1  0 ❌ ±0 

Results for commit c7bac8f. ± Comparison against base commit 7d755ff.

This pull request removes 48 and adds 27 tests. Note that renamed tests count towards both.
  PARTITION BY db1.t1.col2 ORDER BY db1.t1.col1
  PARTITION BY t1.col2 ORDER BY t1.col1
  ROWS_RANGE BETWEEN 3 PRECEDING AND CURRENT ROW
 ) limit 10;](1)
 ) limit 10;](2)
 ) limit 10;](3)
 FROM db1.t1
 FROM t1
 WINDOW w1 AS (
 last join db2.t2 order by db2.t2.col1
…
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlLastJoinWithMultipleDB[,  SELECT sum(db1.t1.col1) over w1 as sum_t1_col1, db2.t2.str1 as t2_str1
 FROM db1.t1
 last join db2.t2 order by db2.t2.col1
 on db1.t1.col1 = db2.t2.col1 and db1.t1.col2 = db2.t2.col0
 WINDOW w1 AS (
  PARTITION BY db1.t1.col2 ORDER BY db1.t1.col1
  ROWS_RANGE BETWEEN 3 PRECEDING AND CURRENT ROW
 ) limit 10;](2)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlLastJoinWithMultipleDB[db1,  SELECT sum(t1.col1) over w1 as sum_t1_col1, db2.t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = db2.t2.col1 and t1.col2 = db2.t2.col0
 WINDOW w1 AS (
  PARTITION BY t1.col2 ORDER BY t1.col1
  ROWS_RANGE BETWEEN 3 PRECEDING AND CURRENT ROW
 ) limit 10;](1)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlLastJoinWithMultipleDB[null,  SELECT sum(db1.t1.col1) over w1 as sum_t1_col1, db2.t2.str1 as t2_str1
 FROM db1.t1
 last join db2.t2 order by db2.t2.col1
 on db1.t1.col1 = db2.t2.col1 and db1.t1.col2 = db2.t2.col0
 WINDOW w1 AS (
  PARTITION BY db1.t1.col2 ORDER BY db1.t1.col1
  ROWS_RANGE BETWEEN 3 PRECEDING AND CURRENT ROW
 ) limit 10;](3)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlMultipleDBErrorTest[, SELECT db2.t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = db2.t2.col1 and t1.col2 = db2.t2.col0;
, SQL parse error: Fail to transform data provider op: table t1 not exists in database []](4)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlMultipleDBErrorTest[db1, SELECT db1.t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = db2.t2.col1 and t1.col2 = db2.t2.col0;
, SQL parse error: Column Not found: db1.t2.str1](2)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlMultipleDBErrorTest[db1, SELECT db2.t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = t2.col1 and t1.col2 = db2.t2.col0;
, SQL parse error: Column Not found: .t2.col1](3)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlMultipleDBErrorTest[db1, SELECT t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = db2.t2.col1 and t1.col2 = db2.t2.col0;
, SQL parse error: Column Not found: .t2.str1](1)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlMultipleDBErrorTest[null, SELECT db2.t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = db2.t2.col1 and t1.col2 = db2.t2.col0;
, SQL parse error: Fail to transform data provider op: table t1 not exists in database []](5)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlWindowLastJoin[ SELECT sum(t1.col1) over w1 as sum_t1_col1, t2.str1 as t2_str1
 FROM t1
 last join t2 order by t2.col1
 on t1.col1 = t2.col1 and t1.col2 = t2.col0
 WINDOW w1 AS (
  PARTITION BY t1.col2 ORDER BY t1.col1
  ROWS_RANGE BETWEEN 3 PRECEDING AND CURRENT ROW
 ) limit 10;](1)
com._4paradigm.openmldb.jdbc.SQLRouterSmokeTest ‑ testInsertMeta[com._4paradigm.openmldb.sdk.impl.SqlClusterExecutor@13809363](1)
…
This pull request skips 1 test.
tests.sqlalchemy_api_test.TestSqlalchemyAPI ‑ test_request_timeout

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7d755ff) 74.91% compared to head (c7bac8f) 40.09%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@              Coverage Diff              @@
##               main    #3736       +/-   ##
=============================================
- Coverage     74.91%   40.09%   -34.83%     
- Complexity      655      657        +2     
=============================================
  Files           732      193      -539     
  Lines        131613    11414   -120199     
  Branches       1366     1374        +8     
=============================================
- Hits          98595     4576    -94019     
+ Misses        32719     6535    -26184     
- Partials        299      303        +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jan 31, 2024

Linux Test Report

    57 files  +     5     244 suites  +187   1h 19m 5s ⏱️ + 51m 9s
12 577 tests +12 029  12 570 ✅ +12 028  7 💤 +3  0 ❌  - 2 
17 834 runs  +17 285  17 827 ✅ +17 284  7 💤 +3  0 ❌  - 2 

Results for commit c7bac8f. ± Comparison against base commit 7d755ff.

♻️ This comment has been updated with latest results.

@github-actions github-actions bot added the workflow CICD related label Feb 1, 2024
@github-actions github-actions bot removed the workflow CICD related label Feb 4, 2024
@github-actions github-actions bot added the workflow CICD related label Feb 4, 2024
Copy link
Collaborator

@tobegit3hub tobegit3hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dl239 dl239 merged commit 7b8a04a into 4paradigm:main Feb 22, 2024
22 of 24 checks passed
@dl239 dl239 deleted the feat/upgrade_thirdparty branch February 22, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build openmldb compiling and installing docker openmldb compile image or demo image workflow CICD related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants