Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add zk auth #3581

Merged
merged 8 commits into from
Nov 15, 2023
Merged

feat: add zk auth #3581

merged 8 commits into from
Nov 15, 2023

Conversation

dl239
Copy link
Collaborator

@dl239 dl239 commented Nov 7, 2023

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

@github-actions github-actions bot added the storage-engine openmldb storage engine. nameserver & tablet label Nov 7, 2023
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Attention: 29 lines in your changes are missing coverage. Please review.

Comparison is base (190992d) 75.33% compared to head (bf6c82c) 75.34%.
Report is 14 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3581      +/-   ##
============================================
+ Coverage     75.33%   75.34%   +0.01%     
- Complexity      587      588       +1     
============================================
  Files           718      717       -1     
  Lines        129780   129723      -57     
  Branches       1280     1282       +2     
============================================
- Hits          97765    97742      -23     
+ Misses        31729    31711      -18     
+ Partials        286      270      -16     
Files Coverage Δ
...in/java/com/_4paradigm/openmldb/sdk/SdkOption.java 84.44% <100.00%> (+0.72%) ⬆️
src/nameserver/cluster_info.cc 46.71% <100.00%> (+0.39%) ⬆️
src/nameserver/name_server_create_remote_test.cc 98.78% <ø> (ø)
src/nameserver/name_server_impl.cc 44.74% <100.00%> (-0.12%) ⬇️
src/nameserver/name_server_test.cc 91.99% <100.00%> (ø)
src/nameserver/new_server_env_test.cc 89.31% <100.00%> (+0.08%) ⬆️
src/sdk/db_sdk.cc 64.34% <100.00%> (-3.78%) ⬇️
src/sdk/db_sdk.h 92.85% <100.00%> (+0.17%) ⬆️
src/sdk/sql_cluster_router.cc 60.12% <100.00%> (-0.01%) ⬇️
src/sdk/sql_router.h 42.85% <ø> (ø)
... and 13 more

... and 52 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added sdk openmldb java/python sdk task-manager openmldb taskmanager labels Nov 7, 2023
@dl239 dl239 marked this pull request as ready for review November 8, 2023 02:07
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 13, 2023
@dl239 dl239 enabled auto-merge (squash) November 14, 2023 07:09
@dl239 dl239 disabled auto-merge November 14, 2023 09:49
@dl239 dl239 merged commit 2fb650a into 4paradigm:main Nov 15, 2023
24 of 26 checks passed
@dl239 dl239 deleted the feat/zk_auth branch November 15, 2023 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation sdk openmldb java/python sdk storage-engine openmldb storage engine. nameserver & tablet task-manager openmldb taskmanager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants