Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add/#83/service guide(swm 344) #84

Merged
merged 8 commits into from
Oct 13, 2023
Merged

Add/#83/service guide(swm 344) #84

merged 8 commits into from
Oct 13, 2023

Conversation

oikkoikk
Copy link
Member

Motivation πŸ€”

  • 슀룸 μ„œλΉ„μŠ€λ₯Ό 처음 μ΄μš©ν•΄λ³΄λŠ” μ‚¬μš©μžλ“€μ˜ μ„œλΉ„μŠ€ 이해도λ₯Ό 높이기 μœ„ν•¨

Key changes βœ…

μ„œλΉ„μŠ€ 이용 κ°€μ΄λ“œ λͺ¨λ‹¬

ezgif com-video-to-gif (25)

  • Notion νŒ€μŠ€νŽ˜μ΄μŠ€μ— 슀룸 μ„œλΉ„μŠ€ 이용 κ°€μ΄λ“œ μž‘μ„±
    • κ°•μ˜ 검색 및 μΆ”μ²œ
    • ν•™μŠ΅ 일정 관리
    • κ°•μ˜ λ…ΈνŠΈ 및 ν€΄μ¦ˆ
  • 상단 헀더에 μ—°κ²° (아직 λ“±λ‘ν•œ κ°•μ˜κ°€ μ—†λŠ” μ‚¬μš©μžμ—κ²Œλ§Œ λ…ΈμΆœ)
    • 기본적으둜 Notion νŽ˜μ΄μ§€λŠ” iframe을 μ°¨λ‹¨ν•˜κ³  있기 λ•Œλ¬Έμ—, react-notion-x 라이브러리λ₯Ό 톡해 κ΅¬ν˜„

μžμž˜ν•œ 였λ₯˜ μˆ˜μ •

  • λ‘œκ·Έμ•„μ›ƒ -> 둜그인 μ‹œ, λ‹€μ‹œ λ‘œκ·Έμ•„μ›ƒ νŽ˜μ΄μ§€κ°€ λœ¨λŠ” 였λ₯˜ μˆ˜μ •
  • session refresh 쑰건 μˆ˜μ •

To reviewers πŸ™

  • μ•„μ΄μ½˜μ€ free 3D icon μ€‘μ—μ„œ μ λ‹Ήν•œ κ±° κ³¨λΌλ΄€μ–΄μš”
  • UI 뿐만 μ•„λ‹ˆλΌ, λ‚΄μš©μ μΈ μΈ‘λ©΄μ—μ„œ μˆ˜μ •ν•΄μ•Ό ν•  뢀뢄이 μžˆλŠ”μ§€ ν™•μΈν•΄μ£Όμ„Έμš”

@oikkoikk oikkoikk added documentation Improvements or additions to documentation feat New feature or request labels Oct 12, 2023
@oikkoikk oikkoikk self-assigned this Oct 12, 2023
@oikkoikk oikkoikk linked an issue Oct 12, 2023 that may be closed by this pull request
[SWM-344] Add Service Guide Documents #83
Closed
@Son-GyeongSik
Copy link
Member

μ„Έμ…˜ μ—λŸ¬ ν•΄κ²°λœκ±° ν™•μΈν–ˆκ³ 
μ•ˆλ‚΄ νŽ˜μ΄μ§€λ„ 이쁘게 잘 λ‚˜μ˜΅λ‹ˆλ‹€! μˆ˜κ³ ν•˜μ…¨μŠ΅λ‹ˆλ‹€~!

@oikkoikk oikkoikk merged commit 5ef83e7 into main Oct 13, 2023
@oikkoikk oikkoikk deleted the add/#83/service-guide(swm-344) branch October 13, 2023 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Son-GyeongSik Son-GyeongSik Awaiting requested review from Son-GyeongSik

@D-w-nJ D-w-nJ Awaiting requested review from D-w-nJ

Assignees

@oikkoikk oikkoikk

Labels
documentation Improvements or additions to documentation feat New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SWM-344] Add Service Guide Documents
2 participants
@oikkoikk @Son-GyeongSik