Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking โ€œSign up for GitHubโ€, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/#79/text loop animation(swm 341) #80

Merged
merged 7 commits into from
Oct 8, 2023

Conversation

oikkoikk
Copy link
Member

@oikkoikk oikkoikk commented Oct 8, 2023 โ€ข

Motivation ๐Ÿค”

  • ํ…์ŠคํŠธ ์• ๋‹ˆ๋ฉ”์ด์…˜์˜ ๋ฌดํ•œ ๋ฃจํ”„ ํƒ€์ด๋ฐ์ด ๋งž์ง€ ์•Š์•„ ๊ฒน์ณ ๋ณด์ด๋Š” ํ˜„์ƒ ๋ฐœ์ƒ

Key changes โœ…

ํ…์ŠคํŠธ ์• ๋‹ˆ๋ฉ”์ด์…˜ ์ˆ˜์ •

  • ๊ธฐ์กด์— ํƒ€์ด๋ฐ์ด ๋งž์ง€ ์•Š์•„ ๊ฒน์ณ๋ณด์ด๊ฑฐ๋‚˜, ๋นˆ ๊ณต๊ฐ„์ด ๋ณด์ด๋˜ ํ˜„์ƒ์„ ์ˆ˜์ •ํ–ˆ์–ด์š”
    ezgif com-crop (5)

๊ธฐ๋ณธ ์ธ๋„ค์ผ ์ด๋ฏธ์ง€ ์ถ”๊ฐ€

  • ์ธ๋„ค์ผ src๊ฐ€ no_thumbnail.jpg๋กœ ๋๋‚˜๋ฉด ๊ธฐ๋ณธ ์ธ๋„ค์ผ์„ ๋ณด์—ฌ์ฃผ๋„๋ก ๊ตฌํ˜„ํ–ˆ์–ด์š”
    แ„€แ…ตแ„‡แ…ฉแ†ซ แ„Šแ…ฅแ†ทแ„‚แ…ฆแ„‹แ…ตแ†ฏ

open-graph ์ด๋ฏธ์ง€ ์ถ”๊ฐ€

  • ์นด์นด์˜คํ†ก, ํŠธ์œ„ํ„ฐ, ํŽ˜์ด์Šค๋ถ ๋“ฑ SNS์— ๋งํฌ๋ฅผ ์˜ฌ๋ฆฌ๋ฉด open-graph ์ด๋ฏธ์ง€๊ฐ€ ๋œจ๋„๋ก ํ–ˆ์–ด์š”
    opengraph-image

์ž์ž˜ํ•œ ์ˆ˜์ •์‚ฌํ•ญ

  • ๋ฐฑ๊ทธ๋ผ์šด๋“œ์—์„œ session์ด ์ž๋™์œผ๋กœ ์—ฐ์žฅ๋˜์ง€ ์•Š๋˜ ์˜ค๋ฅ˜๋ฅผ ์ˆ˜์ •ํ–ˆ์–ด์š”
  • ์ƒ์„ธํ•œ ์˜ค๋ฅ˜ description์„ ๋…ธ์ถœํ•˜์ง€ ์•Š๊ธฐ ์œ„ํ•ด, ๊ธฐ๋ณธ ์—๋Ÿฌ ๋ฉ”์‹œ์ง€๋ฅผ ์˜ค๋ฅ˜๊ฐ€ ๋ฐœ์ƒํ–ˆ์–ด์š”๋กœ ์„ค์ •ํ–ˆ์–ด์š”
  • ํ”„๋กœํ•„ ๋“œ๋กญ๋‹ค์šด์— ์žˆ๋˜ ๊ฐ•์˜ ์ž๋ฃŒ Link ๋ฒ„ํŠผ์„ ์‚ญ์ œํ–ˆ์–ด์š”

To reviewers ๐Ÿ™

  • ์ˆ˜์ •๋˜์ง€ ์•Š์€ ์˜ค๋ฅ˜๊ฐ€ ์žˆ๋Š”์ง€ ํ™•์ธํ•ด์ฃผ์„ธ์š”

@oikkoikk oikkoikk added the fix Something isn't working label Oct 8, 2023
@oikkoikk oikkoikk self-assigned this Oct 8, 2023
@oikkoikk oikkoikk linked an issue Oct 8, 2023 that may be closed by this pull request
@Son-GyeongSik
Copy link
Member

LGTM~ ์ˆ˜๊ณ ํ•˜์…จ์Šต๋‹ˆ๋‹ค!

@D-w-nJ
Copy link
Member

D-w-nJ commented Oct 8, 2023

open graph ๋ฉ‹์žˆ์Šต๋‹ˆ๋‹ค

@oikkoikk oikkoikk merged commit a9881f4 into main Oct 8, 2023
1 of 2 checks passed
@oikkoikk oikkoikk deleted the fix/#79/text-loop-animation(swm-341) branch October 8, 2023 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SWM-341] Fix Text Banner Infinite Loop Animation
3 participants