Refactor/#119/refactor responsibility driven design(swm 361) #128

D-w-nJ · 2023-10-28T10:57:58Z

Motivation 🤔

장멘토님의 피드백을 받아 service 계층 코드를 리팩토링 합니다.

Key changes ✅

Video, Playlist는 Content 라는 추상클래스를 상속받습니다.
Quiz 추상클래스의 구현클래스는 객관식 (MultipleChoice), 주관식(ShortAnswer), TF(TFQuetion)입니다.
Youtube Mapper를 만들어서 youtube data api를 직접 사용하는 YoutubeApi객체와 다른 Service 계층간의 결합도를 낮췄습니다.
PlaylistService, VideoService를 생성하여 응집도를 높였습니다.
CourseCreator, CourseServiceHelper, QuizService 등을 추가하여 응집도를 높이고 책임을 나누었습니다.

To reviewers 🙏

제대로 수행되는지 확인해주세요
패키지 구조가 이상하지 않는지 확인해주세요
메서드, 클래스명 등 네이밍이 이상하지않는지 봐주세요

main에 머지할 때 api 키를 변경하겠습니다. 죄송합니다.

…-design(swm-361)

…-361)' of https://github.com/4m9d/sroom-be into refactor/#119/refactor-responsibility-driven-design(swm-361)

D-w-nJ · 2023-10-30T02:00:12Z

src/main/java/com/m9d/sroom/review/service/ReviewService.java

다른 패키지 구조와 마찬가지로 service 패키지를 삭제해 주세요

D-w-nJ and others added 20 commits October 16, 2023 21:40

[SWM-361] Refactor : refactor package structure

c30e960

[SWM-361] Refactor : course enroll logic

58f8e12

[SWM-361] Refactor : refactor GET /lectures, lecture keyword search api

81779d6

[SWM-261] Refactor : refactor GET /course/{courseId}

ad7c944

[SWM-361] Refactor : refactor PUT /lectures/{courseVideoId}/time api

724b69f

hide api key

8948921

main에 머지할 때 api 키를 변경하겠습니다. 죄송합니다.

[SWM-261] Refactor : refactor GET /material/{courseVideoId} api

bca8886

[SWM-361] Refactor : material apis

4a0a8ad

Refactor : material saver

d3312ac

Fix : refresh token without access token

cfe518b

[SWM-361] Refactor : refactor youtube api method name

bdc1fa9

[SWM-361] Refactor : youtube service to mapper

7440322

[SWM-361] Refactor : remove EnrollCondition class

5cc1b18

[SWM-361] fix : modify package name (lecture -> search)

5181d29

[SWM-361] fix : relocation vo files (common -> each package)

13190fb

[SWM-384] refactor : recommendation refactoring

ca66c5a

[SWM-384] Refactor : 2 section recommendations refactor

e0af386

[SWM-382] Refactor : my course room refactor

e59facc

[SWM-380] Fix : fix course view duration bug

53faf03

Feat : add course not found case

958b579

D-w-nJ requested review from Son-GyeongSik and oikkoikk October 28, 2023 10:57

D-w-nJ linked an issue Oct 28, 2023 that may be closed by this pull request

[SWM-361] Refactor : Responsibility driven design #119

Closed

D-w-nJ and others added 7 commits October 28, 2023 20:33

conflict resolved

4d4f6bc

Merge branch 'main' into refactor/#119/refactor-responsibility-driven…

50c7ef3

…-design(swm-361)

[SWM-383] Refactor : Dashboard refactor

432a25d

Fix : change expires_at field to access_expires_at in login response

753587a

Merge branch 'refactor/#119/refactor-responsibility-driven-design(swm…

b17d96e

…-361)' of https://github.com/4m9d/sroom-be into refactor/#119/refactor-responsibility-driven-design(swm-361)

Fix : update videoEntity with youtube remaining summary id

f78f487

Fix : handle error in grading multiple choice quiz

4936d70

D-w-nJ commented Oct 30, 2023

View reviewed changes

D-w-nJ added 2 commits October 30, 2023 12:42

save course progress according to video count

e96d371

feat : course video progress to 100 in case fully watched

659d0fc

D-w-nJ merged commit 99d4090 into main Oct 30, 2023
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor/#119/refactor responsibility driven design(swm 361) #128

Refactor/#119/refactor responsibility driven design(swm 361) #128

D-w-nJ commented Oct 28, 2023

D-w-nJ Oct 30, 2023

Refactor/#119/refactor responsibility driven design(swm 361) #128

Refactor/#119/refactor responsibility driven design(swm 361) #128

Conversation

D-w-nJ commented Oct 28, 2023

Motivation 🤔

Key changes ✅

To reviewers 🙏

D-w-nJ Oct 30, 2023

Choose a reason for hiding this comment