Logging fix and enhancement #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrected issue where loglevel in mbusd.conf wasn't parsed correctly. Added support for logfile in mbusd.conf. Updated README and mbusd..conf.example to true-up with "-h" output and new logging options.
kpr0th
force-pushed
the
logging-config
branch
from
99692a4
to
b76ac4b
Compare
Sync'd up verbiage in the usage details with the usage summary.
|
@3cky -- I noticed you made some recent changes. And picked up some of my suggested edits but not all of them. I merged in your upstream changes and then rebased my changes and added a couple more minor cleanups to sync the README and -h details. Note that my code changes were mainly to shore up command line parsing -- I think one or two of the logging-related options didn't actually take effect previously, and invalid parameter values would sometimes crash the app or at least result in unexpected logging options occurring; with the fixes I'm proposing, the logging code is a good bit more robust. Please consider pulling in this PR now that it should merge cleanly again. |
|
Merged. Thanks @kpr0th ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected issue where loglevel in mbusd.conf wasn't parsed correctly. Added support for logfile in mbusd.conf. Enhanced validation for loglevel and logfile [added missing validation in cfg.c, fixed error message for loglevel > 2 in non-DEBUG mode, added checks for missing logfile name which was previously treated as STDOUT only).
Updated README and mbusd..conf.example to true-up with "-h" output and new logging options.