Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cryptonono's location #3613

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

GeorgianaElena
Copy link
Member

@GeorgianaElena GeorgianaElena commented Jan 12, 2024

The repo has moved under a new account: https://github.com/cryptnono/cryptnono (see cryptnono/cryptnono#25 (comment))

Copy link

Merging this PR will trigger the following deployment actions.

Support and Staging deployments

Cloud Provider Cluster Name Upgrade Support? Reason for Support Redeploy Upgrade Staging? Reason for Staging Redeploy
gcp leap Yes Support helm chart has been modified No
gcp catalystproject-latam Yes Support helm chart has been modified No
aws ubc-eoas Yes Support helm chart has been modified No
aws gridsst Yes Support helm chart has been modified No
kubeconfig utoronto Yes Support helm chart has been modified No
aws nasa-esdis Yes Support helm chart has been modified No
gcp linked-earth Yes Support helm chart has been modified No
gcp cloudbank Yes Support helm chart has been modified No
gcp awi-ciroh Yes Support helm chart has been modified No
aws nasa-veda Yes Support helm chart has been modified No
aws victor Yes Support helm chart has been modified No
gcp hhmi Yes Support helm chart has been modified No
gcp 2i2c Yes Support helm chart has been modified No
gcp meom-ige Yes Support helm chart has been modified No
aws nasa-cryo Yes Support helm chart has been modified No
aws 2i2c-aws-us Yes Support helm chart has been modified No
gcp qcl Yes Support helm chart has been modified No
gcp callysto Yes Support helm chart has been modified No
gcp pangeo-hubs Yes Support helm chart has been modified No
aws openscapes Yes Support helm chart has been modified No
aws jupyter-meets-the-earth Yes Support helm chart has been modified No
aws nasa-ghg Yes Support helm chart has been modified No
aws catalystproject-africa Yes Support helm chart has been modified No
aws smithsonian Yes Support helm chart has been modified No
gcp 2i2c-uk Yes Support helm chart has been modified No

Production deployments

No production hub upgrades will be triggered

@sgibson91
Copy link
Member

Ha, maybe a premature approval there :D

@GeorgianaElena
Copy link
Member Author

Hmm, is there any caching happening? I see it trying to fetch the chart from the original location still:

Downloading cryptnono from repo https://cryptnono.github.io/cryptnono/
Save error occurred:  could not download https://yuvipanda.github.io/cryptnono/cryptnono-0.3.1-0.dev.git.107.heb504bc.tgz: failed to fetch 

@sgibson91
Copy link
Member

From the error message, I think it's still trying to pull the old repo. So it may be a "merge and hope" scenario, due to how the repo is getting checked out in CI.

@sgibson91
Copy link
Member

Does it work locally? I'm not sure that we cache anything helm chart related in CI. I think it's likely running as if on master and not executing the change

@sgibson91
Copy link
Member

We may also want to consider this PR https://github.com/2i2c-org/infrastructure/pull/3482/files

@GeorgianaElena
Copy link
Member Author

Hmm, I just checked and same happens locally 🤔

@sgibson91
Copy link
Member

sgibson91 commented Jan 12, 2024

This website is a 404 https://cryptnono.github.io/cryptnono/

@sgibson91
Copy link
Member

sgibson91 commented Jan 12, 2024

Seems the repo is still trying to deploy to https://yuvipanda.github.io/cryptnono but that is now also a 404

https://github.com/cryptnono/cryptnono/deployments/github-pages

@sgibson91
Copy link
Member

I opened an issue cryptnono/cryptnono#26

@GeorgianaElena
Copy link
Member Author

This website is a 404 https://cryptnono.github.io/cryptnono/

I believe that is acceptable, but https://cryptnono.github.io/cryptnono/cryptnono-0.3.1-0.dev.git.107.heb504bc.tgz has appropriate resource.

Seems the repo is still trying to deploy to yuvipanda.github.io/cryptnono but that is now also a 404

So maybe the workflows need updating?

@sgibson91
Copy link
Member

sgibson91 commented Jan 12, 2024

So maybe the workflows need updating?

But that's what this PR is doing, which leads me back to my original assumption that we hit merge and hope?

In the sense that it's something funky about what context GitHub Actions is running the workflow on. It will be running the version of the workflow that's in master on the changes in this PR.

ETA: Sorry, realised you may have meant on the cryptnono repo, not here

@yuvipanda
Copy link
Member

Sorry, I moved it for this blog post (2i2c-org/2i2c-org.github.io#205) but somehow thought github will also do redirects for the generated gh-pages stuff (not just the repo).

I'm going to merge this to unblock folks.

@yuvipanda yuvipanda merged commit e2dc5fe into 2i2c-org:master Jan 12, 2024
8 of 33 checks passed
Copy link

🎉🎉🎉🎉

Monitor the deployment of the hubs here 👉 https://github.com/2i2c-org/infrastructure/actions/runs/7504949158

@GeorgianaElena
Copy link
Member Author

So this is failing on the main branch as well :( I've opened cryptnono/cryptnono#28 but not sure if that's enough to fix things?

@yuvipanda
Copy link
Member

cryptnono/cryptnono#27 and cryptnono/cryptnono#29 seem to have fixed it.

@GeorgianaElena GeorgianaElena deleted the chnage-cryptonono branch January 12, 2024 16:59
@GeorgianaElena
Copy link
Member Author

Yaay! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done 🎉
Development

Successfully merging this pull request may close these issues.

3 participants