Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop overriding hub.readinessProbe to false #3257

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

consideRatio
Copy link
Contributor

@consideRatio consideRatio commented Oct 11, 2023

The hub should never enter a "unready" state after it has become ready, but its helpful if it doesn't end up ready before its actually ready as well.

In the past, we've disabled hub.readinessProbe because:

  1. It could lead to cluttering of logs, but it doesn't any more with a modern jupyterhub version
  2. It could fail and making the hub unavailable - even though there wasn't another hub pod replica to delegate traffic to instead etc. It won't do this anymore though - the livenessProbe would fail first if that was the case.

If a hub readinessProbe exists, it can help with wait conditions. For example if helm upgrades with --wait, it will ensure the container doesn't crash before it becomes ready - but without a readinessProbe its considered ready directly, so helm may think its fine even though it entered a crashloop.

@github-actions
Copy link

Merging this PR will trigger the following deployment actions.

Support and Staging deployments

Cloud Provider Cluster Name Upgrade Support? Reason for Support Redeploy Upgrade Staging? Reason for Staging Redeploy
aws openscapes No Yes Following helm chart values files were modified: common.values.yaml
kubeconfig utoronto No Yes Following helm chart values files were modified: common.values.yaml

Production deployments

Cloud Provider Cluster Name Hub Name Reason for Redeploy
aws openscapes prod Following helm chart values files were modified: common.values.yaml
kubeconfig utoronto prod Following helm chart values files were modified: common.values.yaml
kubeconfig utoronto r-prod Following helm chart values files were modified: common.values.yaml

@consideRatio consideRatio marked this pull request as ready for review October 11, 2023 16:16
@consideRatio consideRatio requested a review from a team as a code owner October 11, 2023 16:16
@consideRatio consideRatio mentioned this pull request Oct 11, 2023
@consideRatio consideRatio merged commit 75119bf into 2i2c-org:master Oct 18, 2023
8 checks passed
@github-actions
Copy link

🎉🎉🎉🎉

Monitor the deployment of the hubs here 👉 https://github.com/2i2c-org/infrastructure/actions/runs/6557260917

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done 🎉
Development

Successfully merging this pull request may close these issues.

2 participants