Stop overriding hub.readinessProbe to false #3257
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hub should never enter a "unready" state after it has become ready, but its helpful if it doesn't end up ready before its actually ready as well.
In the past, we've disabled
hub.readinessProbe
because:If a hub readinessProbe exists, it can help with wait conditions. For example if
helm
upgrades with--wait
, it will ensure the container doesn't crash before it becomes ready - but without a readinessProbe its considered ready directly, sohelm
may think its fine even though it entered a crashloop.