Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[utoronto] Undo Jupyter ServerApp usage to fix jupyter-nbcontrib-extensions #2411

Merged
merged 2 commits into from
Mar 22, 2023
Merged

[utoronto] Undo Jupyter ServerApp usage to fix jupyter-nbcontrib-extensions #2411

merged 2 commits into from
Mar 22, 2023

Conversation

yuvipanda
Copy link
Member

@yuvipanda yuvipanda commented Mar 22, 2023 •
edited
Loading

@yuvipanda
Undo Jupyter ServerApp usage to fix jupyter-nbcontrib-extensions
082e8bf 
jupyter-nbcontrib-extensions required the following fixes to
work:

1. Pin nbclassic<0.5 (done in
   2i2c-org/utoronto-image#49, until
   Jupyter-contrib/jupyter_nbextensions_configurator#152
   is merged and released)
2. Upgrade jupyter-nbcontrib-extensions to latest released version
   (done in 2i2c-org/utoronto-image#48)
3. Stop using ServerApp, and use NotebookApp (issue to be filed here)

Ref 2i2c-org/utoronto-image#48
@yuvipanda yuvipanda requested a review from a team March 22, 2023 17:30
@github-actions
Copy link

Merging this PR will trigger the following deployment actions.

Support and Staging deployments

Cloud Provider Cluster Name Upgrade Support? Reason for Support Redeploy Upgrade Staging? Reason for Staging Redeploy
kubeconfig utoronto No Yes Following helm chart values files were modified: default-common.values.yaml

Production deployments

Cloud Provider Cluster Name Hub Name Reason for Redeploy
kubeconfig utoronto prod Following helm chart values files were modified: default-common.values.yaml

@yuvipanda
Copy link
Member Author

Tested on utoronto staging. Will need to raise an upstream issue about jupyter_server migration causing more problems here.

@pnasrat pnasrat self-requested a review March 22, 2023 17:46
pnasrat
pnasrat approved these changes Mar 22, 2023
View reviewed changes
Copy link
Contributor

@pnasrat pnasrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Thanks for the great work debugging this

@yuvipanda yuvipanda merged commit 1a03703 into 2i2c-org:master Mar 22, 2023
@github-actions
Copy link

🎉🎉🎉🎉

Monitor the deployment of the hubs here 👉 https://github.com/2i2c-org/infrastructure/actions/runs/4493472252

@yuvipanda yuvipanda mentioned this pull request Mar 22, 2023
Closed
@pnasrat
Copy link
Contributor

pnasrat commented Mar 23, 2023

Should the same be done for the basehub image? I'm not sure how widely used extensions are

@consideRatio consideRatio changed the title Undo Jupyter ServerApp usage to fix jupyter-nbcontrib-extensions [utoronto] Undo Jupyter ServerApp usage to fix jupyter-nbcontrib-extensions Mar 23, 2023
@yuvipanda
Copy link
Member Author

@pnasrat i left a comment in #2336 about what I think we should do with the current image there.

@GeorgianaElena GeorgianaElena mentioned this pull request Mar 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pnasrat pnasrat pnasrat approved these changes

Assignees

@yuvipanda yuvipanda

Labels
None yet
Projects
No open projects
Sprint Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuvipanda @pnasrat