Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify repo2docker workflow #40

Merged
merged 2 commits into from
Nov 22, 2023

Conversation

sgibson91
Copy link
Member

@sgibson91 sgibson91 commented Nov 22, 2023

We had some issues with the workflow, notably that NO_PUSH wasn't ingesting the github conditional correctly and seemingly preventing pushing.

This PR simplifies the workflow to just run after merge for now. I'll do some further debugging to see if I can bring back the build-but-no-push-from-a-pr functionality without resorting to a second workflow file

@sgibson91 sgibson91 force-pushed the debugging-r2d-workflow branch from 9a128c4 to 17084d0 Compare November 22, 2023 12:19
@sgibson91 sgibson91 changed the title [debugging] Disable NO_PUSH option - hence always push the image Simplify repo2docker workflow Nov 22, 2023
- only run on pushes to main
- always push
@sgibson91 sgibson91 force-pushed the debugging-r2d-workflow branch from be46fed to f5d324e Compare November 22, 2023 14:44
@sgibson91
Copy link
Member Author

Will self-merge so the workflow works

@sgibson91 sgibson91 merged commit 77854fa into 2i2c-org:main Nov 22, 2023
@sgibson91 sgibson91 deleted the debugging-r2d-workflow branch November 22, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done 🎉
Development

Successfully merging this pull request may close these issues.

1 participant