Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start cosmetic refactor #2263 #2265

Merged
merged 14 commits into from
Dec 28, 2024
Merged

Start cosmetic refactor #2263 #2265

merged 14 commits into from
Dec 28, 2024

Conversation

theballaam96
Copy link
Collaborator

@theballaam96 theballaam96 commented Dec 22, 2024

  • Refactor the cosmetic writers Split up CosmeticColors.py, and organize #2263
  • Fixed a couple bugged door locations
  • Added a "smoother camera" option which allows for control of the camera with holding C-Left and C-Right. This equates to the same camera turn speed relative to real-time, but enables stopping it at any point, rather than 45 degree markers
  • Removed some pointless prints

Copy link

github-actions bot commented Dec 22, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
22428 10455 47% 0% 🟢

New Files

File Coverage Status
randomizer/Patching/Cosmetics/Colorblind.py 6% 🟢
randomizer/Patching/Cosmetics/CustomTextures.py 9% 🟢
randomizer/Patching/Cosmetics/KongColor.py 18% 🟢
randomizer/Patching/Cosmetics/Krusha.py 20% 🟢
randomizer/Patching/Cosmetics/ModelSwaps.py 21% 🟢
randomizer/Patching/Cosmetics/Puzzles.py 6% 🟢
randomizer/Patching/Cosmetics/TextRando.py 41% 🟢
randomizer/Patching/Cosmetics/init.py 100% 🟢
TOTAL 28% 🟢

Modified Files

File Coverage Status
randomizer/Lists/DoorLocations.py 66% 🟢
randomizer/Patching/ASMPatcher.py 5% 🟢
randomizer/Patching/ApplyRandomizer.py 78% 🟢
randomizer/Patching/CosmeticColors.py 11% 🟢
randomizer/Patching/Lib.py 37% 🟢
randomizer/Patching/LibImage.py 24% 🟢
randomizer/SettingStrings.py 79% 🟢
randomizer/Settings.py 69% 🟢
randomizer/ShuffleDoors.py 29% 🟢
TOTAL 44% 🟢

updated for commit: 8673921 by action🐍

@theballaam96 theballaam96 marked this pull request as ready for review December 27, 2024 23:13
@theballaam96 theballaam96 merged commit 993d133 into dev Dec 28, 2024
5 checks passed
@theballaam96 theballaam96 deleted the cosmetic-refactor branch December 28, 2024 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants