Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split up CosmeticColors.py, and organize #2263

Open
theballaam96 opened this issue Dec 22, 2024 · 3 comments
Open

Split up CosmeticColors.py, and organize #2263

theballaam96 opened this issue Dec 22, 2024 · 3 comments

Comments

@theballaam96
Copy link
Collaborator

4k+ line python file with many functions hurts me

@Killklli
Copy link
Collaborator

Killklli commented Dec 22, 2024

Imo anything above 1k indicates the file should be broken up or refactored.

@theballaam96
Copy link
Collaborator Author

Yea, got a few good splits for this

theballaam96 added a commit that referenced this issue Dec 22, 2024
@theballaam96
Copy link
Collaborator Author

Current progress: CosmeticColors.py is now down to under 2k lines. Still a lot of work to do (Most of that 2k lines is enemy recolors, which I seriously need to refactor to make less of a pain to look at)

Also, I've noticed that the colorblind section needs a serious refactor and rewrite to make it less convoluted. I think this was one of Seagull's first projects, so this makes sense. The colorblind file is sitting at a little over 1k lines, and I think we can get it to under 700 with a bit of refactor

theballaam96 added a commit that referenced this issue Dec 28, 2024
@theballaam96 theballaam96 moved this from In Progress to Needs Testing in DK64 Randomizer Release V4.0 Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Needs Testing
Development

No branches or pull requests

2 participants