chore: 공용 스타일 파일 디테일 수정 #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21ow
approved these changes
Dec 20, 2024
| @import url('https://cdn.jsdelivr.net/gh/orioncactus/[email protected]/dist/web/variable/pretendardvariable.min.css'); | ||
| @import '@/_asset/reset.scss'; | ||
| @import '@/asset/reset.scss'; |
There was a problem hiding this comment.
✋질문 있습니다.
기존 방식이 globals에서 reset, variables를 import해서 관리하는 방식이었잖아요?
variables는 config에서 전역으로 사용 가능하게 바꾸신 거고요.
reset도 config에 추가해서 사용하는 게 가능할까요??
어차피 variables처럼 전역으로 사용되는 파일이니까??
| $radi-category-small: 6px; | ||
| $radi-category-filter: 100px; | ||
| $radi-modal: 16px; | ||
| $radius-common: 8px; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
asset 명 수정 및 variables 파일 수정
📸 Screenshot
📢 Notes