sink #95
Merged
sink #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🐞FIX: 첫 렌더링 시 일정 리스트 상단에 date picker가 고정되지 않는 버그 수정 > 배포 환경 적용
1. app header 컴포넌트에서 로그아웃 버튼을 눌렀을 때 트리거되는 함수명을 수정했습니다. 2. app header에서 userId Prop을 따로 사용하지 않아 지워줬습니다. 3. exChange.jsx 파일에서 useEffect() 훅의 사용이 불필요하게 분리되어있어, 합쳐주었습니다. 4. exchange.jsx에서 사용하지 않는 base-currency 클래스를 지워줬습니다.
1. sign up 컴포넌트에서의 사용하지 않는 빈 div를 삭제 2. Mypage 컴포넌트에서 클래스명을 github로 주던 것을 isSocialLogin이라는 좀 더 semantic한 이름으로 변경 3. my page path를 모바일 디바이스로 보았을 떄, 뒤로가기 버튼이 보이지 않는 것을 해결하기 위해 margin-top 속성을 padding-top으로 바꾸어 배경색도 유지하고 해결하려고 시도 4. signup에서 클래스명이 단순히 check인 것은 에러메시지를 표현하는 것에 적합하지 않아 checkIsValid로 바꿔줌
✅ Deploy Preview for two-guys-travel-project ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.