Skip to content

Commit

Permalink
Bump minimum supported Python version from 3.8 to 3.9 (#116)
Browse files Browse the repository at this point in the history
* Bump minimum supported Python version from 3.8 to 3.9

Fixes #115

* Remove codecov from workflow

Currently no PRs can be merged since the codecov step doesn't work anymore. Fixing that is a lengthy process, so to temporarily unblock important PRs from being merged (i.e. #116, #114, #107), we will remove this from our pipeline.

---------

Co-authored-by: Eddy Filip <[email protected]>
  • Loading branch information
michaelAbon1p and edif2008 authored Dec 19, 2024
1 parent 06bc175 commit 8871fe0
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 98 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
- name: Setup Python
uses: actions/setup-python@v1
with:
python-version: 3.8
python-version: 3.9
- name: Install dependencies
run: |
python -m pip install --upgrade pip
Expand Down
14 changes: 4 additions & 10 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
name: Tests
permissions:
contents: read
on:
push:
branches: main
on:
push:
branches: main
pull_request:

jobs:
Expand All @@ -14,7 +14,7 @@ jobs:
- name: Setup Python
uses: actions/setup-python@v1
with:
python-version: 3.8
python-version: 3.9
- name: Check out code
uses: actions/checkout@v2
- name: Install dependencies
Expand All @@ -25,9 +25,3 @@ jobs:
- name: Test
run: |
poetry run pytest src/tests --cov=./ --cov-report=xml
- name: Upload coverage to Codecov
uses: codecov/codecov-action@v2
with:
fail_ci_if_error: true
files: ./coverage.xml
token: ${{ secrets.CODECOV_TOKEN }}
93 changes: 7 additions & 86 deletions poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ repository = "https://github.com/1Password/connect-sdk-python"
"Report Security Issue" = "https://bugcrowd.com/agilebits"

[tool.poetry.dependencies]
python = "^3.7"
python = "^3.9"
python-dateutil = "^2.8.1"
httpx = "^0.23.3"

Expand Down

0 comments on commit 8871fe0

Please sign in to comment.