Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add priorityClassName for the Operator and Connect deployment #176

Closed
wants to merge 3 commits into from
Closed

Feature: Add priorityClassName for the Operator and Connect deployment #176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bdf4231
Add priorityClassName for the Operator and Connect deployment
jkrusy Oct 16, 2023
b5d4f0f
Add priorityClassName for the Operator and Connect deployment
jkrusy Oct 16, 2023
dad19d0
Merge remote-tracking branch 'origin/priority-class' into priority-class
jkrusy Oct 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions charts/connect/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,14 +100,15 @@ helm install --set connect.applicationName=connect connect ./connect
| connect.tls.secret | string | `"op-connect-tls"` | The name of the secret containing the TLS key (`tls.key`) and certificate (`tls.crt`) |
| connect.tolerations | list | `[]` | List of tolerations to be added to the Connect API pods. |
| connect.version | string | `{{.Chart.AppVersion}}` | The 1Password Connect version to pull |
| connect.priorityClassName | string | `""` | The name of the 1Password Connect priority class |
| operator.autoRestart | boolean | `false` | Denotes whether the 1Password Operator will automatically restart deployments based on associated updated secrets. |
| operator.create | boolean | `false` | Denotes whether the 1Password Operator will be deployed |
| operator.imagePullPolicy | string | `"IfNotPresent"` | The 1Password Operator image pull policy |
| operator.imageRepository | string | `"1password/onepassword-operator"` | The 1Password Operator repository |
| operator.nodeSelector | object | `{}` | [Node selector](https://kubernetes.io/docs/concepts/scheduling-eviction/assign-pod-node/#nodeselector) stanza for the operator pod |
| operator.annotations | object | `{}` | Additional annotations to be added to the Operator deployment resource. |
| operator.labels | object | `{}` | Additional labels to be added to the Operator deployment resource. |
| operator.logLevel | string | `info` | Log level of the Operator container. Valid options are: debug, info and error. |
| operator.logLevel | string | `info` | Log level of the Operator container. Valid options are: debug, info and error. |
| operator.podAnnotations | object | `{}` | Additional annotations to be added to the Operator pods. |
| operator.podLabels | object | `{}` | Additional labels to be added to the Operator pods. |
| operator.pollingInterval | integer | `600` | How often the 1Password Operator will poll for secrets updates. |
Expand All @@ -118,7 +119,8 @@ helm install --set connect.applicationName=connect connect ./connect
| operator.roleBinding.name | string | `"onepassword-connect-operator"` | The name of the 1Password Operator Role Binding |
| operator.serviceAccount.annotations | object | `{}` | Annotations for the 1Password Connect Service Account |
| operator.serviceAccount.create | boolean | `{{.Values.operator.create}}` | Denotes whether or not a service account will be created for the 1Password Operator |
| operator.serviceAccount.name | string | `"onepassword-connect-operator"` | The name of the 1Password Conenct Operator |
| operator.serviceAccount.name | string | `"onepassword-connect-operator"` | The name of the 1Password Connect Operator |
| operator.priorityClassName | string | `""` | The name of the priority class for the 1Password Connect Operator |
| operator.tolerations | list | `[]` | List of tolerations to be added to the Operator pods. |
| operator.version | string | `"1.8.0"` | T 1Password Operator version to pull |
| operator.token.key | string | `"token"` | The key for the 1Password Connect token stored in the 1Password token secret |
Expand Down
3 changes: 3 additions & 0 deletions charts/connect/templates/connect-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,9 @@ spec:
secret:
secretName: {{ .Values.connect.tls.secret }}
{{- end }}
{{- with .Values.connect.priorityClassName }}
priorityClassName: {{ . }}
{{- end }}
tolerations:
{{ toYaml .Values.connect.tolerations | indent 8 }}
containers:
Expand Down
3 changes: 3 additions & 0 deletions charts/connect/templates/operator-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,9 @@ spec:
tolerations:
{{ toYaml .Values.operator.tolerations | indent 8 }}
serviceAccountName: {{ .Values.operator.serviceAccount.name }}
{{- with .Values.operator.priorityClassName }}
priorityClassName: {{ . }}
{{- end }}
containers:
- name: {{ .Values.connect.applicationName }}
image: {{ .Values.operator.imageRepository }}:{{ .Values.operator.version | default "latest" }}
Expand Down
6 changes: 6 additions & 0 deletions charts/connect/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,9 @@ connect:
# Number of profiler snapshots to keep.
keepLast: 12

# 1Password Connect PriorityClass Name
priorityClassName: ""

# This section of values is for 1Password Operator Configuration
operator:
# Denotes whether the 1Password Operator will be deployed
Expand Down Expand Up @@ -259,6 +262,9 @@ operator:
# The name of the 1Password Conenct Operator
name: onepassword-connect-operator

# 1Password Operator PriorityClass Name
priorityClassName: ""

# 1Password Operator Role Binding Configuration
roleBinding:
# Denotes whether or not a role binding will be created for each Namespace for the 1Password Operator Service Account
Expand Down
Loading