Add HPA, PDB and Pod Affinity for both Operator and Connect components #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dapama
commented
Aug 25, 2023
dapama
commented
- Add "replicas" variable for Operator deployment.
- Add pod Affinity for both Connect and Operator deployments.
- Add Horizontal Pod Autoscaling and Pod Disruption Budget resources for both Connect and Operator deployments.
|
Hello Onepassword team! Is it also raised here. So you will make at least 8 people happy, solve 1 github issue and introduce 2 new features on your helm chart. Thank you! cc: @jillianwilson |
|
Thanks for reminding us about this, @alexbescond! We'll pick it up for review shortly and (at least) add an update here. (And thanks again @dapama for opening this PR!) |
|
@michaelAbon1p hi, this PR is crucial for us (1pass business client). 1pass operator is a key part of our infra and being able to set affinity and pod disruption budgets is crucial. I was wondering what's the hold up here or if there could be any help needed to accelerate such PR? thanks for the help, much appreciated |
volodymyrZotov
force-pushed
the
add-hpa-pdb-affinity
branch
from
20d1a8f to
a0a154c
Compare
…nity # Conflicts: # charts/connect/README.md # charts/connect/templates/connect-deployment.yaml # charts/connect/templates/operator-deployment.yaml
volodymyrZotov
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.