Skip to content

Commit

Permalink
fix: default connect.serviceType to ClusterIP
Browse files Browse the repository at this point in the history
Fixes #194
  • Loading branch information
bo0tzz authored Dec 12, 2024
1 parent ae40372 commit dd3a26f
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion charts/connect/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ helm install --set connect.applicationName=connect connect ./connect
| connect.labels | object | `{}` | Additional labels to be added to the Connect API deployment resource. |
| connect.podAnnotations | object | `{}` | Additional annotations to be added to the Connect API pods. |
| connect.podLabels | object | `{}` | Additional labels to be added to the Connect API pods. |
| connect.serviceType | string | `NodePort` | The type of Service resource to create for the Connect API and sync services. |
| connect.serviceType | string | `ClusterIP` | The type of Service resource to create for the Connect API and sync services. |
| connect.serviceAnnotations | object | `{}` | Additional annotations to be added to the service. |
| connect.sync.imageRepository | string | `"1password/connect-sync"` | The 1Password Connect Sync repository |
| connect.sync.name | string | `"connect-sync"` | The name of the 1Password Connect Sync container |
Expand Down
4 changes: 2 additions & 2 deletions charts/connect/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -62,10 +62,10 @@ connect:

# The type of Service resource to create for the Connect API and sync services.
# See: https://kubernetes.io/docs/concepts/services-networking/service
# This by default is NodePort and can also be defined as LoadBalancer.
# This by default is ClusterIP and can also be defined as NodePort or LoadBalancer.
# If serviceType is LoadBalancer then loadBalancerSourceRanges and loadBalancerIP should be defined.
# See: https://kubernetes.io/docs/concepts/services-networking/service/#loadbalancer
serviceType: NodePort
serviceType: ClusterIP

# Additional annotations to be added to the service resource
serviceAnnotations: {}
Expand Down

0 comments on commit dd3a26f

Please sign in to comment.