Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style edits to release checklist page #750

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Style edits to release checklist page #750

wants to merge 1 commit into from

Conversation

alexsobledotgov
Copy link
Contributor

@alexsobledotgov alexsobledotgov commented Nov 13, 2024 •
edited
Loading

🔗 Preview link

Changes

This is a follow-on PR to #741 that adjusts a few things:

  • Style and grammar updates
  • Use "launch" instead of "release" consistently in the new Guide page
  • Adjust page order within "our approach section" -- multiple pages had page order set to 10

Security considerations

N/A

alexsobledotgov
alexsobledotgov commented Nov 14, 2024
View reviewed changes
content/engineering/our-approach/release-strategies.md
order: 10
order: 9
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

three different pages currently have order: 10, which isn't helpful for setting page order!

alexsobledotgov
alexsobledotgov commented Nov 14, 2024
View reviewed changes
content/engineering/our-approach/people/assessment.md
order: 10
order: 12
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

three different pages currently have order: 10, which isn't helpful for setting page order!

@alexsobledotgov alexsobledotgov changed the title [WIP] Style edits to release checklist page Style edits to release checklist page Nov 14, 2024
@alexsobledotgov alexsobledotgov marked this pull request as ready for review November 14, 2024 18:38
@alexsobledotgov alexsobledotgov requested a review from a team as a code owner November 14, 2024 18:38
@alexsobledotgov alexsobledotgov requested review from kewlguy781 and hbillings and removed request for a team November 14, 2024 18:38
@alexsobledotgov
Copy link
Contributor Author

@kewlguy781 and @hbillings -- follow-on PR to #741 ready for your review

kewlguy781
kewlguy781 approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@kewlguy781 kewlguy781 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me. thanks for helping clean up this. We may want to communicate with the guides/TLC to keep eyes on the pages order navbar when adding new pages to the guides.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kewlguy781 kewlguy781 kewlguy781 approved these changes

@hbillings hbillings Awaiting requested review from hbillings

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexsobledotgov @kewlguy781