This repository has been archived by the owner on Dec 8, 2017. It is now read-only.
Most of the way towards a cal implementation for #11 #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using icalendar node lib to generate ics files server side. The major outstanding issue here is that solr is not returning the results I'd expect. I search for id="some_id" and it returns many results which don't contain the id. I think I am just missing something (hopefully) obvious.
| var result = results_in.response.docs[0]; | ||
|
|
||
| // Got good results, create the calendar event | ||
| var ev = new icalendar.VEvent(uuid.v4()); |
There was a problem hiding this comment.
If someone "subscribes" to the calendar (such as putting it in Google Calendar), having a different UUID every time the endpoint is hit will result in the calendar app thinking they are different calendar entries. An alternative would be to use the id, or hash the id.
There was a problem hiding this comment.
This happens when someone accesses the .ics file through webcal:// rather than https://
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using iCalendar package (from Midas fame) to generate ics files server side. The major outstanding issue here is that solr is not returning the results I'd expect. I search for id="some_id" and it returns many results which don't contain the id. I think I am just missing something (hopefully) obvious.
I set it up as a /v0/cal/record_id endpoint since that made the most sense to me for this particular issue. But it may make more sense to make it a query parameter based endpoint if there is a desire to build calendars with multiple events in the future.