Merge pull request #1629 from 18F/rmh-3124-idk-clearance-xml

Encode "I don't know" clearance level
18F · Apr 23, 2019 · 2fecf4a · 2fecf4a
2 parents 93349ef + 8806957
commit 2fecf4a
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/api/templates/legal-investigations-investigated.xml b/api/templates/legal-investigations-investigated.xml
@@ -13,8 +13,11 @@
     <OtherAgency>{{text $Item.AgencyExplanation}}</OtherAgency>
     {{end}}
     {{end}}
-    <!-- XXX https://github.com/18F/e-QIP-prototype/issues/1489 -->
+    {{if notApplicable $Item.ClearanceLevelNotApplicable | eq "True"}}
+    <ClearanceLevel>Unknown</ClearanceLevel>
+    {{else}}
     <ClearanceLevel>{{radio $Item.ClearanceLevel.props.Level | clearanceType}}</ClearanceLevel>
+    {{end}}
     <EntryComment></EntryComment>
     <GrantedDate>
       {{monthYearOptional $Item.Granted $Item.GrantedNotApplicable}}

diff --git a/api/testdata/complete-scenarios/test6.json b/api/testdata/complete-scenarios/test6.json
@@ -2635,7 +2635,7 @@
                       "Level": {
                         "type": "radio",
                         "props": {
-                          "value": "None"
+                          "value": ""
                         }
                       },
                       "Explanation": {
@@ -2649,7 +2649,7 @@
                   "ClearanceLevelNotApplicable": {
                     "type": "notapplicable",
                     "props": {
-                      "applicable": true
+                      "applicable": false
                     }
                   },
                   "Completed": {

diff --git a/api/testdata/complete-scenarios/test6.xml b/api/testdata/complete-scenarios/test6.xml
@@ -992,7 +992,7 @@
               <Investigations>
                 <Investigation ID="1">
                   <Agency>Unknown</Agency>
-                  <ClearanceLevel>None</ClearanceLevel>
+                  <ClearanceLevel>Unknown</ClearanceLevel>
                   <GrantedDate>
                     <Date DoNotKnow="True">