-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/1.2.2 #107
Release/1.2.2 #107
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for handling the release!
Seeing some test failures for wordfence and wpscan, worth checking those to see if there's something amiss that we need to account for here. cc: @felipeelia @burhandodhy @iamdharmesh (as folks who helped on the primary PRs on the release) |
I've fixed the Wordfence failures so we're good there. Looks like the output they return has changed slightly, which is what we look for in our tests, so had to update the test to account for that. For WPScan, these are failing due to our API key not having access: |
I've reached out to WPScan to see if we can get a slightly elevated account above the 25 API daily calls limit. |
Do we want to proceed with the release here or wait for that API increase first? |
I'm fine proceeding as I don't expect to hear back too quickly from WPScan on increased API limit. |
Description of the Change
Version bump and prep for the 1.2.2 release
Closes #106
How to test the Change
Verify all file changes look accurate and tests pass
Changelog Entry
n/a
Credits
Props @dkotter
Checklist: