Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filter to skip vulnerability check. #101

Merged
merged 3 commits into from
Feb 22, 2024
Merged

Add filter to skip vulnerability check. #101

merged 3 commits into from
Feb 22, 2024

Conversation

burhandodhy
Copy link
Contributor

Description of the Change

This PR introduce the new filter vuln_skip_vulnerability_check to skip the vulnerability.

Closes #100

How to test the Change

Changelog Entry

Added - Introduce new filter vuln_skip_vulnerability_check

Credits

Props @burhandodhy

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

Copy link
Member

@iamdharmesh iamdharmesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, @burhandodhy. The code looks good to me, but I believe we need to apply the same filters to other providers as well. This way, it can work for all scans, regardless of the provider we choose. Currently, this is implemented for the Wordfence; we also need to do the same for Patchstack (here) and WPScan.

Thank you.

@burhandodhy
Copy link
Contributor Author

Hi @iamdharmesh,

Thanks for your feedback. I updated the code. Do you mind giving it another try?

Copy link
Member

@iamdharmesh iamdharmesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the making changes @burhandodhy. LGTM now.

@iamdharmesh iamdharmesh merged commit ac00960 into develop Feb 22, 2024
3 of 4 checks passed
@iamdharmesh iamdharmesh deleted the fix/100 branch February 22, 2024 12:51
@dkotter dkotter modified the milestones: 1.3.0, 1.2.1 Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce filter hook!
5 participants