Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop distributing development files #143

Closed
wants to merge 2 commits into from

Conversation

szepeviktor
Copy link
Contributor

Resolves #97

Here is how to test.

git archive HEAD | tar --list

@szepeviktor szepeviktor requested a review from a team as a code owner August 13, 2023 10:21
@szepeviktor szepeviktor requested review from peterwilsoncc and removed request for a team August 13, 2023 10:21
@szepeviktor
Copy link
Contributor Author

@jeffpaul jeffpaul added this to the 2.2.0 milestone Aug 14, 2023
@dkotter dkotter modified the milestones: 2.2.0, 2.2.1 Aug 17, 2023
@peterwilsoncc
Copy link
Contributor

@szepeviktor Thanks for the pull request and linking to your workflow file.

The generated zip file contains a few files that are listed in the .gitignore file. By default git archive ignores these files, do you know if there is a method that will allow safe-svg to include these files when generating the zip file via git archive?

The affected files are:

  • built assets in the /dist directory
  • production assets included in the /vendor directory

I've hit a few road-blocks trying to figure it out, so would value any input.

@szepeviktor
Copy link
Contributor Author

szepeviktor commented Sep 1, 2023

do you know if there is a method that will allow safe-svg to include these files

There is an option for that: https://git-scm.com/docs/git-archive#Documentation/git-archive.txt---add-fileltfilegt

BTW .gitignore is unrelated to .gitattributes

@dkotter dkotter modified the milestones: 2.2.1, 2.3.0 Oct 19, 2023
@jeffpaul
Copy link
Member

jeffpaul commented Jan 2, 2024

Isn't this covered by the .distignore file?

@szepeviktor
Copy link
Contributor Author

Maybe.
Composer uses GitHub ZIP, those are not affected by distignore.

@jeffpaul jeffpaul modified the milestones: 2.2.5, 2.3.0 Jun 27, 2024
@jeffpaul
Copy link
Member

Closing in favor of alternate handling of #97 in #220.

@jeffpaul jeffpaul closed this Aug 30, 2024
@dkotter dkotter removed this from the 2.3.0 milestone Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NPM archive related scripts include node_modules and vendor files in zip.
4 participants