Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] ajoute la feature de campagne external-id(Pix-14659) #10260

Merged

Conversation

lionelB
Copy link
Member

@lionelB lionelB commented Oct 7, 2024

🦄 Problème

On souhaiterait permettre la validation des identifiants externes, afin de limiter mes erreurs de saisie notamment lorsqu'on demande une adresse mail

🤖 Proposition

On commence par migrer les données existantes dans les nouvelles tables de features

🌈 Remarques

RAS

💯 Pour tester

  • Se connecter sur la RA avec le client pg de scalingo
  • faire une requete sur campaigns et lister les idPixLabel
  • faire une requete sur campaign-features
  • constater qu'on retrouve les meme infos (campaignId, idPixLabel)

@lionelB lionelB requested a review from a team as a code owner October 7, 2024 12:10
@lionelB lionelB self-assigned this Oct 7, 2024
@lionelB lionelB changed the title feat(api): add campaign_feature table with externalid feature [FEATURE] ajoute la feature de campagne external-id(Pix-14659) Oct 7, 2024
@pix-bot-github
Copy link

Une fois les applications déployées, elles seront accessibles via les liens suivants :

Les variables d'environnement seront accessibles via les liens suivants :

@lionelB lionelB changed the title [FEATURE] ajoute la feature de campagne external-id(Pix-14659) [FEATURE] ajoute la feature de campagne external-id(Pix-14659) Oct 7, 2024
@lionelB lionelB requested review from a team and removed request for a team October 7, 2024 12:12
@xav-car
Copy link
Contributor

xav-car commented Oct 7, 2024

c'est OKAY !

@lionelB lionelB force-pushed the pix-14659/add-campaign-feature-and-migrate-data branch from 625f332 to 4b09f47 Compare October 7, 2024 15:52
@lionelB lionelB force-pushed the pix-14659/add-campaign-feature-and-migrate-data branch from 4b09f47 to 038addf Compare October 7, 2024 16:06
Copy link
Contributor

@xav-car xav-car left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Goooo

@lionelB lionelB closed this Oct 7, 2024
@lionelB lionelB reopened this Oct 7, 2024
@pix-bot-github
Copy link

Une fois les applications déployées, elles seront accessibles via les liens suivants :

Les variables d'environnement seront accessibles via les liens suivants :

@pix-service-auto-merge pix-service-auto-merge merged commit f1a56f7 into dev Oct 7, 2024
9 of 12 checks passed
@pix-service-auto-merge pix-service-auto-merge deleted the pix-14659/add-campaign-feature-and-migrate-data branch October 7, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants