🐛 api: SCO whitelist must not allow blank lines

1024pix · Oct 8, 2024 · 173621e · 173621e
1 parent d4d4baa
commit 173621e
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/api/src/shared/config.js b/api/src/shared/config.js
@@ -6,6 +6,7 @@ import * as url from 'node:url';
 import dayjs from 'dayjs';
 import ms from 'ms';
 
+import { _ } from './infrastructure/utils/lodash-utils.js';
 import { getArrayOfUpperStrings } from './infrastructure/utils/string-utils.js';
 
 const __dirname = url.fileURLToPath(new URL('.', import.meta.url));
@@ -185,7 +186,9 @@ const configuration = (function () {
       newYearOrganizationLearnersImportDate: _getDate(process.env.NEW_YEAR_ORGANIZATION_LEARNERS_IMPORT_DATE),
       numberOfChallengesForFlashMethod: _getNumber(process.env.NUMBER_OF_CHALLENGES_FOR_FLASH_METHOD),
       successProbabilityThreshold: parseFloat(process.env.SUCCESS_PROBABILITY_THRESHOLD ?? '0.95'),
-      pixCertifScoBlockedAccessWhitelist: getArrayOfUpperStrings(process.env.PIX_CERTIF_SCO_BLOCKED_ACCESS_WHITELIST),
+      pixCertifScoBlockedAccessWhitelist: getArrayOfUpperStrings(
+        process.env.PIX_CERTIF_SCO_BLOCKED_ACCESS_WHITELIST,
+      ).filter((externalId) => !_.isBlank(externalId)),
       pixCertifScoBlockedAccessDateLycee: process.env.PIX_CERTIF_SCO_BLOCKED_ACCESS_DATE_LYCEE,
       pixCertifScoBlockedAccessDateCollege: process.env.PIX_CERTIF_SCO_BLOCKED_ACCESS_DATE_COLLEGE,
       scheduleComputeOrganizationLearnersCertificability: {