fix: BarNote getSVGElement always returning undefined #1618
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BarNote is not opening its own context group which means it fails to perform operations requiring the id of the Element such as getSVGElement, addClass, removeClass etc.
I also added barline as a property of barnote to memoize it and have direct access to the barline if one needs it.
It looks like there are not any tests for the barnote directly but I added a test for the error scenario I was running into where getSVGElement was always returning undefined for rendered BarNotes