This repository has been archived by the owner on Dec 4, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The original idea behind this PR was to resolve the following security findings
This PR aims to fix the following security checks that are related to cross-site scripting attack vector.
Idea was to escape HTML content from response using
template.HTMLEscape
, but it turns out that when doing so, that function fails internally.So the behavior is reverted to the old one (response is written into the buffer directly) and unit tests which proves that we don't have an issue are added.
Mentioned security issues are going to be marked as not relevant.
Changes include
Checklist
Testing